Skip to content

Conversation

@sanpwc
Copy link
Contributor

@sanpwc sanpwc commented Aug 4, 2023

Thank you for submitting the pull request.

In order to streamline the review of the patch and ensure better code quality
we ask both an author and a reviewer to check the following requirements:

The Review Checklist

  • Formal criteria: TC status, codestyle, mandatory documentation. Also check the following list:
    - There is a single JIRA ticket related to the pull request.
    - The web-link to the pull request is attached to the JIRA ticket.
    - The JIRA ticket has the Patch Available state.
    - The description of the JIRA ticket explains WHAT and WHY was made and HOW.
    - The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • Design: new code conforms with the design principles of the components it is added to.
  • Patch quality: patch cannot be split into a smaller pieces, its size is reasonable.
  • Code quality: code is clean and readable, necessary developer documentation is added if needed.
  • Tests code quality: tests set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.

Notes

sanpwc added 18 commits June 13, 2023 12:26
…-18856

# Conflicts:
#	modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/leases/Lease.java
#	modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/leases/LeaseTracker.java
#	modules/runner/src/integrationTest/java/org/apache/ignite/internal/table/ItTableScanTest.java
#	modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java
#	modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/framework/NoOpTransaction.java
#	modules/table/build.gradle
#	modules/table/src/integrationTest/java/org/apache/ignite/distributed/ItAbstractInternalTableScanTest.java
#	modules/table/src/integrationTest/java/org/apache/ignite/distributed/ItInternalTableReadWriteScanTest.java
#	modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java
#	modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java
#	modules/table/src/testFixtures/java/org/apache/ignite/internal/table/TxAbstractTest.java
…-18856

# Conflicts:
#	modules/table/src/main/java/org/apache/ignite/internal/table/InternalTable.java
#	modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java
…-18856

# Conflicts:
#	modules/table/src/main/java/org/apache/ignite/internal/table/InternalTable.java
#	modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java
…-18856

# Conflicts:
#	modules/table/src/main/java/org/apache/ignite/internal/table/InternalTable.java
#	modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java
…-18856-2

# Conflicts:
#	modules/client/src/test/java/org/apache/ignite/client/fakes/FakeIgnite.java
#	modules/sql-engine/build.gradle
#	modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/MockedStructuresTest.java
#	modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java
…-18856-2

# Conflicts:
#	modules/client/src/test/java/org/apache/ignite/client/fakes/FakeIgnite.java
#	modules/sql-engine/build.gradle
#	modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/MockedStructuresTest.java
#	modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java
…-18856-2

# Conflicts:
#	modules/client/src/test/java/org/apache/ignite/client/fakes/FakeIgnite.java
#	modules/sql-engine/build.gradle
#	modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/MockedStructuresTest.java
#	modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java
…-18856-2

# Conflicts:
#	modules/client/src/test/java/org/apache/ignite/client/fakes/FakeIgnite.java
#	modules/sql-engine/build.gradle
#	modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/MockedStructuresTest.java
#	modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java
@sanpwc sanpwc closed this Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant