Skip to content

IGNITE-18965: Sql. CREATE TABLE fails when a column with DEFAULT constraint NULL is present.#2489

Merged
korlov42 merged 1 commit into
apache:mainfrom
gridgain:IGNITE-18965
Aug 25, 2023
Merged

IGNITE-18965: Sql. CREATE TABLE fails when a column with DEFAULT constraint NULL is present.#2489
korlov42 merged 1 commit into
apache:mainfrom
gridgain:IGNITE-18965

Conversation

@lowka
Copy link
Copy Markdown
Contributor

@lowka lowka commented Aug 23, 2023

Fixes handling of NULL literal in DEFAULT NULL constraint of CREATE TABLE command.

https://issues.apache.org/jira/browse/IGNITE-18965


Thank you for submitting the pull request.

To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:

The Review Checklist

  • Formal criteria: TC status, codestyle, mandatory documentation. Also make sure to complete the following:
    - There is a single JIRA ticket related to the pull request.
    - The web-link to the pull request is attached to the JIRA ticket.
    - The JIRA ticket has the Patch Available state.
    - The description of the JIRA ticket explains WHAT was made, WHY and HOW.
    - The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • Design: new code conforms with the design principles of the components it is added to.
  • Patch quality: patch cannot be split into smaller pieces, its size must be reasonable.
  • Code quality: code is clean and readable, necessary developer documentation is added if needed.
  • Tests code quality: test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.

Notes

@lowka lowka force-pushed the IGNITE-18965 branch 7 times, most recently from 6014596 to 69d66d5 Compare August 23, 2023 15:38
@lowka lowka marked this pull request as ready for review August 24, 2023 08:07
@korlov42 korlov42 merged commit 53a36f2 into apache:main Aug 25, 2023
@korlov42 korlov42 deleted the IGNITE-18965 branch August 25, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants