Skip to content

IGNITE-20422 Add events of becoming and ceasing to be a primary replica in the PlacementDriver #2596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tkalkirill merged 20 commits into from
Sep 22, 2023
Merged

IGNITE-20422 Add events of becoming and ceasing to be a primary replica in the PlacementDriver #2596

tkalkirill merged 20 commits into from
Sep 22, 2023

Conversation

@tkalkirill
Copy link
Contributor

@tkalkirill tkalkirill commented Sep 18, 2023

https://issues.apache.org/jira/browse/IGNITE-20422

Thank you for submitting the pull request.

To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:

The Review Checklist

  • Formal criteria: TC status, codestyle, mandatory documentation. Also make sure to complete the following:
    - There is a single JIRA ticket related to the pull request.
    - The web-link to the pull request is attached to the JIRA ticket.
    - The JIRA ticket has the Patch Available state.
    - The description of the JIRA ticket explains WHAT was made, WHY and HOW.
    - The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • Design: new code conforms with the design principles of the components it is added to.
  • Patch quality: patch cannot be split into smaller pieces, its size must be reasonable.
  • Code quality: code is clean and readable, necessary developer documentation is added if needed.
  • Tests code quality: test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.

Notes

sashapolo
sashapolo reviewed Sep 18, 2023
View reviewed changes
...ver/src/integrationTest/java/org/apache/ignite/internal/placementdriver/ActiveActorTest.java
) {
when(msm.recoveryFinishedFuture()).thenReturn(completedFuture(0L));
when(msm.invoke(any(), any(Operation.class), any(Operation.class))).thenReturn(completedFuture(true));
when(msm.getLocally(any(), anyLong())).then(invocation -> emptyMetastoreEntry());
Copy link
Contributor

@sashapolo sashapolo Sep 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need to mock this?

Copy link
Contributor Author

@tkalkirill tkalkirill Sep 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid getting null in Entry entry = msManager.getLocally(PLACEMENTDRIVER_LEASES_KEY, recoveryRevision);, which will lead to NPE.

sanpwc
sanpwc reviewed Sep 21, 2023
View reviewed changes
@tkalkirill tkalkirill merged commit 29b0cb1 into apache:main Sep 22, 2023
@tkalkirill tkalkirill deleted the ignite-20422 branch September 22, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sashapolo sashapolo sashapolo approved these changes

@sanpwc sanpwc sanpwc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tkalkirill @sashapolo @sanpwc