Skip to content

IGNITE-20757 Add a module for utility applications#2795

Merged
sashapolo merged 4 commits intoapache:mainfrom
gridgain:ignite-20757
Nov 6, 2023
Merged

IGNITE-20757 Add a module for utility applications#2795
sashapolo merged 4 commits intoapache:mainfrom
gridgain:ignite-20757

Conversation

@sashapolo
Copy link
Contributor

https://issues.apache.org/jira/browse/IGNITE-20757

Thank you for submitting the pull request.

To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:

The Review Checklist

  • Formal criteria: TC status, codestyle, mandatory documentation. Also make sure to complete the following:
    - There is a single JIRA ticket related to the pull request.
    - The web-link to the pull request is attached to the JIRA ticket.
    - The JIRA ticket has the Patch Available state.
    - The description of the JIRA ticket explains WHAT was made, WHY and HOW.
    - The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • Design: new code conforms with the design principles of the components it is added to.
  • Patch quality: patch cannot be split into smaller pieces, its size must be reasonable.
  • Code quality: code is clean and readable, necessary developer documentation is added if needed.
  • Tests code quality: test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.

Notes

Copy link
Contributor

@rpuch rpuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A DBMS might have utilities useful for end users, but here it's utilities for the developers. Is it ok to take the name 'utilities'? Maybe it would be better to rename to 'dev-utilities'?

@sashapolo sashapolo merged commit f765418 into apache:main Nov 6, 2023
@sashapolo sashapolo deleted the ignite-20757 branch November 6, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments