IGNITE-15298 Partitions raft snapshots #285
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SammyVimes
force-pushed
the
ignite-15298
branch
2 times, most recently
from
fe17e44 to
d91b3d8
Compare
sashapolo
reviewed
Aug 20, 2021
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/Storage.java
Outdated
Show resolved
Hide resolved
...storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbStorage.java
Outdated
Show resolved
Hide resolved
...storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbStorage.java
Outdated
Show resolved
Hide resolved
...tegrationTest/java/org/apache/ignite/raft/client/service/ITAbstractListenerSnapshotTest.java
Outdated
Show resolved
Hide resolved
...tegrationTest/java/org/apache/ignite/raft/client/service/ITAbstractListenerSnapshotTest.java
Outdated
Show resolved
Hide resolved
...tegrationTest/java/org/apache/ignite/raft/client/service/ITAbstractListenerSnapshotTest.java
Outdated
Show resolved
Hide resolved
...tegrationTest/java/org/apache/ignite/raft/client/service/ITAbstractListenerSnapshotTest.java
Outdated
Show resolved
Hide resolved
| * @param interactedAfterSnapshot {@code true} whether raft group was interacted with after the snapshot operation. | ||
| * @return Closure. | ||
| */ | ||
| public abstract BooleanSupplier snapshotCheckClosure(JRaftServerImpl restarted, boolean interactedAfterSnapshot); |
Contributor
There was a problem hiding this comment.
Actually I think that all these abstract methods are a sign of over-engineering. Do we really need an abstract class for these two tests? I think it is easier to copy-paste the test itself....
Contributor
Author
There was a problem hiding this comment.
Tests are basically the same, any change in the raft group API would require changes in two places
Contributor
There was a problem hiding this comment.
Yes, but all these abstract methods show that they are not really the same, only the overall test scenario
Contributor
Author
There was a problem hiding this comment.
I think raft set up, stop and restart operations are too complicated to copy-paste them. I don't see how abstract tests can hurt us
...les/table/src/integrationTest/java/org/apache/ignite/distributed/ITTablePersistenceTest.java
Outdated
Show resolved
Hide resolved
...les/table/src/integrationTest/java/org/apache/ignite/distributed/ITTablePersistenceTest.java
Outdated
Show resolved
Hide resolved
SammyVimes
force-pushed
the
ignite-15298
branch
from
e1265df to
ba67f54
Compare
sashapolo
reviewed
Aug 20, 2021
modules/rocksdb-common/src/main/java/org/apache/ignite/internal/rocksdb/RocksUtils.java
Outdated
Show resolved
Hide resolved
modules/rocksdb-common/src/main/java/org/apache/ignite/internal/rocksdb/RocksUtils.java
Outdated
Show resolved
Hide resolved
SammyVimes
force-pushed
the
ignite-15298
branch
2 times, most recently
from
d17bd70 to
92362fe
Compare
Co-authored-by: Alexander Polovtcev <alex.polovtcev@gmail.com>
SammyVimes
force-pushed
the
ignite-15298
branch
from
92362fe to
2d4f121
Compare
ygerzhedovich
pushed a commit
that referenced
this pull request
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-15298