-
Notifications
You must be signed in to change notification settings - Fork 137
IGNITE-20863 Selecting indexes when performing update operations for partition #2859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
modules/index/src/main/java/org/apache/ignite/internal/index/IndexCollector.java
Outdated
Show resolved
Hide resolved
modules/index/src/main/java/org/apache/ignite/internal/index/IndexCollector.java
Show resolved
Hide resolved
modules/index/src/main/java/org/apache/ignite/internal/index/IndexCollector.java
Outdated
Show resolved
Hide resolved
modules/index/src/main/java/org/apache/ignite/internal/index/IndexCollector.java
Show resolved
Hide resolved
modules/index/src/main/java/org/apache/ignite/internal/index/IndexCollector.java
Outdated
Show resolved
Hide resolved
modules/index/src/main/java/org/apache/ignite/internal/index/IndexCollector.java
Outdated
Show resolved
Hide resolved
modules/index/src/main/java/org/apache/ignite/internal/index/IndexCollector.java
Outdated
Show resolved
Hide resolved
modules/index/src/main/java/org/apache/ignite/internal/index/IndexCollector.java
Outdated
Show resolved
Hide resolved
modules/index/src/main/java/org/apache/ignite/internal/index/IndexCollector.java
Show resolved
Hide resolved
|
|
||
| createTable(catalogManager, TABLE_NAME, COLUMN_NAME); | ||
|
|
||
| tableId = tableId(catalogManager, TABLE_NAME, clock); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's strange we need clock for getting a table ID. The clock is probably used to get the 'latest' version, but this can be done without any clock.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is test code that works, I don’t want to change it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea is that it can be simplified, and it's easy to simplify it (just add an overload that takes no clock parameter, and reuse the old one instantiating a new clock). Right now, when someone reads this code, it might be confusing.
https://issues.apache.org/jira/browse/IGNITE-20863
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
The Review Checklist
- There is a single JIRA ticket related to the pull request.
- The web-link to the pull request is attached to the JIRA ticket.
- The JIRA ticket has the Patch Available state.
- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
Notes