Skip to content

Conversation

@tkalkirill
Copy link
Contributor

https://issues.apache.org/jira/browse/IGNITE-20863

Thank you for submitting the pull request.

To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:

The Review Checklist

  • Formal criteria: TC status, codestyle, mandatory documentation. Also make sure to complete the following:
    - There is a single JIRA ticket related to the pull request.
    - The web-link to the pull request is attached to the JIRA ticket.
    - The JIRA ticket has the Patch Available state.
    - The description of the JIRA ticket explains WHAT was made, WHY and HOW.
    - The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • Design: new code conforms with the design principles of the components it is added to.
  • Patch quality: patch cannot be split into smaller pieces, its size must be reasonable.
  • Code quality: code is clean and readable, necessary developer documentation is added if needed.
  • Tests code quality: test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.

Notes


createTable(catalogManager, TABLE_NAME, COLUMN_NAME);

tableId = tableId(catalogManager, TABLE_NAME, clock);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's strange we need clock for getting a table ID. The clock is probably used to get the 'latest' version, but this can be done without any clock.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is test code that works, I don’t want to change it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea is that it can be simplified, and it's easy to simplify it (just add an overload that takes no clock parameter, and reuse the old one instantiating a new clock). Right now, when someone reads this code, it might be confusing.

@tkalkirill tkalkirill merged commit 3f80b7e into apache:main Nov 23, 2023
@tkalkirill tkalkirill deleted the ignite-20863-v2 branch November 23, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants