Skip to content

Conversation

@kgusakov
Copy link
Contributor

@kgusakov kgusakov commented Nov 28, 2023

https://issues.apache.org/jira/browse/IGNITE-20564

Thank you for submitting the pull request.

To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:

The Review Checklist

  • Formal criteria: TC status, codestyle, mandatory documentation. Also make sure to complete the following:
    - There is a single JIRA ticket related to the pull request.
    - The web-link to the pull request is attached to the JIRA ticket.
    - The JIRA ticket has the Patch Available state.
    - The description of the JIRA ticket explains WHAT was made, WHY and HOW.
    - The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • Design: new code conforms with the design principles of the components it is added to.
  • Patch quality: patch cannot be split into smaller pieces, its size must be reasonable.
  • Code quality: code is clean and readable, necessary developer documentation is added if needed.
  • Tests code quality: test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.

Notes

@kgusakov kgusakov marked this pull request as ready for review November 29, 2023 07:43
@kgusakov kgusakov changed the title IGNITE-20564 IGNITE-20564 Storage profile conigurations Nov 29, 2023
@kgusakov kgusakov changed the title IGNITE-20564 Storage profile conigurations IGNITE-20564 Storage profile configurations Nov 29, 2023
@kgusakov kgusakov changed the base branch from main to storage-profiles November 29, 2023 08:33
Copy link
Contributor

@alievmirza alievmirza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a minor comment, overall, I approve this PR, taking into account further work in https://issues.apache.org/jira/browse/IGNITE-20990

@sanpwc sanpwc merged commit 7748175 into apache:storage-profiles Nov 29, 2023
@sanpwc sanpwc deleted the ignite-20564 branch November 29, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants