IGNITE-21063 Optimize memory usage in optimized marshaller#2950
Merged
ibessonov merged 6 commits intoapache:mainfrom Dec 13, 2023
Merged
IGNITE-21063 Optimize memory usage in optimized marshaller#2950ibessonov merged 6 commits intoapache:mainfrom
ibessonov merged 6 commits intoapache:mainfrom
Conversation
Signed-off-by: ibessonov <bessonov.ip@gmail.com>
Signed-off-by: ibessonov <bessonov.ip@gmail.com>
Signed-off-by: ibessonov <bessonov.ip@gmail.com>
Signed-off-by: ibessonov <bessonov.ip@gmail.com>
tkalkirill
reviewed
Dec 13, 2023
modules/raft/src/main/java/org/apache/ignite/internal/raft/util/DefaultByteBuffersPool.java
Show resolved
Hide resolved
modules/raft/src/main/java/org/apache/ignite/internal/raft/util/DefaultByteBuffersPool.java
Show resolved
Hide resolved
| } | ||
|
|
||
| if (size.get() < capacity && size.getAndIncrement() < capacity) { | ||
| return ByteBuffer.allocate(DEFAULT_BUFFER_SIZE).order(OptimizedMarshaller.ORDER); |
Contributor
There was a problem hiding this comment.
It’s a little unclear to me that it should create a buffer with a default size, can it be passed as an argument?
Contributor
Author
There was a problem hiding this comment.
It can be, but why would I over-complicate things. Maybe default size should be a parameter in the constructor, but do we really need that?
Contributor
There was a problem hiding this comment.
I would do it through the method, the constructor is a little worse, at your discretion.
modules/raft/src/main/java/org/apache/ignite/internal/raft/util/DefaultByteBuffersPool.java
Show resolved
Hide resolved
modules/raft/src/main/java/org/apache/ignite/internal/raft/util/OptimizedMarshaller.java
Show resolved
Hide resolved
modules/raft/src/main/java/org/apache/ignite/internal/raft/util/DefaultByteBuffersPool.java
Show resolved
Hide resolved
Signed-off-by: ibessonov <bessonov.ip@gmail.com>
Signed-off-by: ibessonov <bessonov.ip@gmail.com>
tkalkirill
approved these changes
Dec 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-21063
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
The Review Checklist
- There is a single JIRA ticket related to the pull request.
- The web-link to the pull request is attached to the JIRA ticket.
- The JIRA ticket has the Patch Available state.
- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
Notes