IGNITE-21033 .NET: Fix retry handling with notifications in Compute#2981
Merged
ptupitsyn merged 12 commits intoapache:mainfrom Dec 22, 2023
Merged
IGNITE-21033 .NET: Fix retry handling with notifications in Compute#2981ptupitsyn merged 12 commits intoapache:mainfrom
ptupitsyn merged 12 commits intoapache:mainfrom
Conversation
isapego
approved these changes
Dec 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address the following scenario:
COMPUTE_EXECUTErequest has been sent, but the connection has failed before we got a responseClientSocket.Disposeinvokes all notification handlers withIgniteClientConnectionExceptionRetryPolicykicks in, reconnects the channel and sends anotherCOMPUTE_EXECUTErequest, which leads to a successful task executionTaskCompletionSourceis already completed exceptionally due to the first failureTo fix that,
TaskCompletionSource(NotificationHandler) is now returned with the resultingPooledBufferfromDoOutInOpAsync. This way we ignore notification handlers from failed attempts, and only use the last one.Fixes
TestClientRetriesComputeJobOnPrimaryAndDefaultNodes.Same approach as in Java: #2975