-
Notifications
You must be signed in to change notification settings - Fork 135
IGNITE-14000 Fix codestyle in cli and cli-common modules #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sk0x50
reviewed
Jan 21, 2021
modules/cli/src/main/java/org/apache/ignite/cli/CliPathsConfigLoader.java
Show resolved
Hide resolved
modules/cli/src/main/java/org/apache/ignite/cli/CliPathsConfigLoader.java
Outdated
Show resolved
Hide resolved
modules/cli/src/main/java/org/apache/ignite/cli/CommandFactory.java
Outdated
Show resolved
Hide resolved
modules/cli/src/main/java/org/apache/ignite/cli/IgnitePaths.java
Outdated
Show resolved
Hide resolved
modules/cli/src/main/java/org/apache/ignite/cli/IgnitePaths.java
Outdated
Show resolved
Hide resolved
47bdc14 to
a167da8
Compare
vkulichenko
requested changes
Jan 23, 2021
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cli.common.IgniteCommand interface doesn't have any JavaDoc. Please describe the purpose of the interface, how it should be used, etc.
MavenArtifactResolver has a TODO without a ticket on line 152.
modules/cli/src/main/java/org/apache/ignite/cli/InteractiveWrapper.java
Outdated
Show resolved
Hide resolved
modules/cli/src/main/java/org/apache/ignite/cli/spec/ConfigCommandSpec.java
Outdated
Show resolved
Hide resolved
modules/cli/src/main/java/org/apache/ignite/cli/builtins/config/HttpClientFactory.java
Outdated
Show resolved
Hide resolved
vkulichenko
approved these changes
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.