IGNITE-21496 Make Vault methods synchronous#3189
Merged
sashapolo merged 4 commits intoapache:mainfrom Feb 9, 2024
Merged
Conversation
sashapolo
force-pushed
the
ignite-21496
branch
2 times, most recently
from
4805e06 to
5467acd
Compare
sashapolo
force-pushed
the
ignite-21496
branch
from
5467acd to
c2142e6
Compare
tkalkirill
reviewed
Feb 9, 2024
modules/vault/src/main/java/org/apache/ignite/internal/vault/VaultManager.java
Outdated
Show resolved
Hide resolved
modules/vault/src/main/java/org/apache/ignite/internal/vault/VaultService.java
Outdated
Show resolved
Hide resolved
...vault/src/main/java/org/apache/ignite/internal/vault/persistence/PersistentVaultService.java
Outdated
Show resolved
Hide resolved
...lt/src/testFixtures/java/org/apache/ignite/internal/vault/inmemory/InMemoryVaultService.java
Outdated
Show resolved
Hide resolved
...lt/src/testFixtures/java/org/apache/ignite/internal/vault/inmemory/InMemoryVaultService.java
Outdated
Show resolved
Hide resolved
...lt/src/testFixtures/java/org/apache/ignite/internal/vault/inmemory/InMemoryVaultService.java
Outdated
Show resolved
Hide resolved
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/LowWatermark.java
Outdated
Show resolved
Hide resolved
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/LowWatermark.java
Outdated
Show resolved
Hide resolved
|
|
||
| failureProcessor.process(new FailureContext(CRITICAL_ERROR, throwable)); | ||
|
|
||
| inBusyLock(busyLock, this::scheduleUpdateLowWatermarkBusy); |
Contributor
There was a problem hiding this comment.
Why schedule if the node is likely to die?
Contributor
Author
There was a problem hiding this comment.
This logic was present here before my changes. I guess we still schedule it, because Failure Handler may not be configured to stop the node
sashapolo
force-pushed
the
ignite-21496
branch
from
55468d4 to
15c65a9
Compare
tkalkirill
reviewed
Feb 9, 2024
modules/vault/src/main/java/org/apache/ignite/internal/vault/VaultManager.java
Outdated
Show resolved
Hide resolved
modules/vault/src/main/java/org/apache/ignite/internal/vault/VaultService.java
Outdated
Show resolved
Hide resolved
...vault/src/main/java/org/apache/ignite/internal/vault/persistence/PersistentVaultService.java
Outdated
Show resolved
Hide resolved
...lt/src/testFixtures/java/org/apache/ignite/internal/vault/inmemory/InMemoryVaultService.java
Outdated
Show resolved
Hide resolved
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/LowWatermark.java
Outdated
Show resolved
Hide resolved
tkalkirill
approved these changes
Feb 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-21496
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
The Review Checklist
- There is a single JIRA ticket related to the pull request.
- The web-link to the pull request is attached to the JIRA ticket.
- The JIRA ticket has the Patch Available state.
- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
Notes