IGNITE-21533 Sql. Use actual order of key columns to built key only row #3214
Conversation
korlov42
force-pushed
the
ignite-21533
branch
2 times, most recently
from
f840f35 to
1ec38e8
Compare
korlov42
force-pushed
the
ignite-21533
branch
from
1ec38e8 to
7ee1878
Compare
|
|
||
| boolean hiddenColumnFound = false; | ||
| for (ColumnDescriptor columnDescriptor : desc) { | ||
| if (columnDescriptor.hidden()) { |
There was a problem hiding this comment.
Maybe It would be better to leave a comment explaining why this is needed?
There was a problem hiding this comment.
added comment in the beginning of the method explaining why do we need to omit hidden columns in INSERT
...les/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDmlTest.java
Outdated
Show resolved
Hide resolved
| "'id2,id1', 'id1,id2'", | ||
| "'id2,id1', 'id2,id1'", | ||
| }) | ||
| void test(String pkDefinition, String colocateByDefinition) { |
There was a problem hiding this comment.
should we check the same for disabled rule for KV optimization?
There was a problem hiding this comment.
added 2 more test cases to verify multistep execution
| * @param factory Type factory. | ||
| * @return Row type for INSERT operation. | ||
| */ | ||
| RelDataType insertRowType(IgniteTypeFactory factory); |
There was a problem hiding this comment.
these names looks as action for insert something into table. Maybe will be better to rename it, just for example insertionRowType
There was a problem hiding this comment.
or insertOperationRowType
There was a problem hiding this comment.
renamed to rowTypeForInsert
- add tests to cover multistep operations - improve definition of test cases in CsvSource annotation - rename methods of IgniteTable to better reflect semantic - add comment explaining idea behind hidden columns
3 participants
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
The Review Checklist
- There is a single JIRA ticket related to the pull request.
- The web-link to the pull request is attached to the JIRA ticket.
- The JIRA ticket has the Patch Available state.
- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
Notes