IGNITE-21291 Scan cursors do not close when an RO transaction is finalized #3219
Conversation
| /** | ||
| * Retrieves a collection of transaction UUIDs. | ||
| * | ||
| * @return a collection of transaction UUIDs |
There was a problem hiding this comment.
| * @return a collection of transaction UUIDs | |
| * @return A collection of transaction UUIDs. |
| /** | ||
| * Keeps track of all closed RO transactions. | ||
| */ | ||
| public class ClosedTransactionTracker { |
There was a problem hiding this comment.
In fact, it works only with RO transactions. Maybe rename it to ClosedReadOnlyTransactionTracker?
| */ | ||
| public class ClosedTransactionTracker { | ||
|
|
||
| private static final int maxClosedTransactionsInBatch = 10_000; |
| /** | ||
| * Topology service. | ||
| */ |
There was a problem hiding this comment.
| /** | |
| * Topology service. | |
| */ | |
| /** Topology service. */ |
| UUID txId = TestTransactionIds.TRANSACTION_ID_GENERATOR.transactionIdFor(readTimestamp); | ||
|
|
||
| var tx = new ReadOnlyTransactionImpl(txManager, new HybridTimestampTracker(), txId, "localId", readTimestamp); | ||
| var tx = new ReadOnlyTransactionImpl( |
There was a problem hiding this comment.
What do you think about adding additional tests checking that RO transaction's cursors are closed after its finish?
There was a problem hiding this comment.
Added a test to cover that
| private void processTxCleanup(CloseCursorsBatchMessage closeCursorsMessage) { | ||
| closeCursorsMessage.transactions().forEach(resourcesRegistry::close); | ||
| } |
There was a problem hiding this comment.
Here we can process potentially huge batch of transactions (tracker allows max size of 10k), I an not sure it's a good idea to do this in network thread. What do you think about doing this in cleanup thread within resource cleanup manager in background?
| * Close transaction cursors message. | ||
| */ | ||
| @Transferable(TxMessageGroup.TX_CLOSE_CURSORS) | ||
| public interface CloseCursorsBatchMessage extends TimestampAware { |
There was a problem hiding this comment.
What about FinishedTransactionsBatchMessage?
| int cpus = Runtime.getRuntime().availableProcessors(); | ||
|
|
||
| cleanupExecutor = new ThreadPoolExecutor( | ||
| writeIntentSwitchPool = new ThreadPoolExecutor( |
There was a problem hiding this comment.
It think it's worthy to rename as well
TxManagerImpl#executeCleanupAsyncIgniteThreadFactory.create(nodeName, "tx-async-cleanup", LOG, STORAGE_READ, STORAGE_WRITE)- thread name
...ble/src/integrationTest/java/org/apache/ignite/internal/table/ItTransactionRecoveryTest.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/ignite/internal/tx/impl/FinishedTransactionBatchRequestHandler.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/ignite/internal/tx/impl/FinishedTransactionBatchRequestHandler.java
Outdated
Show resolved
Hide resolved
3 participants
https://issues.apache.org/jira/browse/IGNITE-21291