IGNITE-15361 Thin 3.0: Add KeyValueBinaryView #328
Conversation
# Conflicts: # modules/client/src/main/java/org/apache/ignite/internal/client/table/ClientTable.java # modules/client/src/main/java/org/apache/ignite/internal/client/table/ClientTuple.java # modules/client/src/test/java/org/apache/ignite/client/ClientTableTest.java
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.ignite.client.proto; |
There was a problem hiding this comment.
Do you mean 'proto' is a public package?
Let's move it into 'internal' package or write javadoc to all enum values. WDYT?
| var tuple = readTuple(in, table, true); | ||
|
|
||
| return table.getAndDeleteAsync(tuple).thenAccept(resTuple -> writeTuple(out, resTuple)); | ||
| return table.getAndDeleteAsync(tuple).thenAccept(resTuple -> writeTuple(out, resTuple, TuplePart.VAL)); |
There was a problem hiding this comment.
Do you plan to reuse this (and similar) methods in Table binary view?
I think user expects TableView.get(t) will return full row (key+value parts), but KvView will return "value" part only, thought.
Shouldn't TuplePart be passed from outside?
There was a problem hiding this comment.
Do you plan to reuse this (and similar) methods in Table binary view?
This is a server-side handler. Table and KvView APIs only differ in the way they return data to the user, but the data is the same. There is nothing specific to Table or KvView on the protocol level - all operations are shared.
For Get* operations we only return the value part from the server, because the client already knows the key. For the Table view, we combine returned value columns with known key columns to create the full row and return it to the user.
There was a problem hiding this comment.
I've updated the PR description to clarify this point.
| public enum TuplePart { | ||
| KEY, | ||
| VAL, | ||
| KEY_AND_VAL |
There was a problem hiding this comment.
What about 'contains' operation? It don't require any key or value to be returned.
It's ok if you plan to optimize it later.
There was a problem hiding this comment.
Maybe we should add a separate ticket for this part.
There was a problem hiding this comment.
Good catch, added ClientOp.TUPLE_CONTAINS_KEY.
…est, update contains implementation
3 participants
KeyValueBinaryViewfor Java thin client (ignite.tables().table(..).kvView()).TUPLE_GETpasses the key to the server, and server used to return full tuple: key and value columns. It is not necessary to pass the key back, and the server won't do that anymore.TableandKvViewAPIs - the same operations are used for both. The difference is only on the client side -Tablereturns all columns in a singleTuple, andKvViewsplits key/val columns into separateTuples.IEP updated accordingly: https://cwiki.apache.org/confluence/display/IGNITE/IEP-76+Thin+Client+Protocol+for+Ignite+3.0