IGNITE-21928 Describe Catalog operation flow in README#3585
Merged
korlov42 merged 5 commits intoapache:mainfrom Apr 17, 2024
Merged
IGNITE-21928 Describe Catalog operation flow in README#3585korlov42 merged 5 commits intoapache:mainfrom
korlov42 merged 5 commits intoapache:mainfrom
Conversation
| CatalogManager -> CatalogManager : Acquire catalog of version equal to version from update minus 1 | ||
| CatalogManager -> CatalogManager : Applies updates to the catalog | ||
| CatalogManager -> CatalogManager : Registers new catalog in a local cache | ||
| CatalogManager -> CatalogManager : Notifies other components about changes in catalog |
Contributor
There was a problem hiding this comment.
seems to need to be mentioned in the documentation that CatalogManager can register listeners and notify these listeners about changes
Contributor
Author
There was a problem hiding this comment.
done, mention this is in Base components description section (see definition of CatalogService)
xtern
approved these changes
Apr 12, 2024
modules/catalog/README.md
Outdated
| * [CatalogObjectDescriptor](src/main/java/org/apache/ignite/internal/catalog/descriptors/CatalogObjectDescriptor.java) -- | ||
| base class for objects managed by catalog, like tables, indexes, zones, etc. | ||
| * [CatalogService](src/main/java/org/apache/ignite/internal/catalog/CatalogService.java) -- provides | ||
| methods to access catalog's objects' descriptors of exact version and/or last actual version at |
Contributor
There was a problem hiding this comment.
Is an apostrophe needed in objects'?
Contributor
Author
There was a problem hiding this comment.
yep. Apostrophe goes after s in case of possessive form of a noun that ends with -s
AMashenkov
reviewed
Apr 15, 2024
AMashenkov
reviewed
Apr 15, 2024
AMashenkov
reviewed
Apr 15, 2024
added 2 commits
April 16, 2024 16:25
- rephrase summary a little bit - add information about events - introduce "guarantee" section
ygerzhedovich
approved these changes
Apr 17, 2024
AMashenkov
approved these changes
Apr 17, 2024
xtern
approved these changes
Apr 17, 2024
added 2 commits
April 17, 2024 14:54
- add notes about update log entry serialisation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
The Review Checklist
- There is a single JIRA ticket related to the pull request.
- The web-link to the pull request is attached to the JIRA ticket.
- The JIRA ticket has the Patch Available state.
- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
Notes