Skip to content

IGNITE-22817 Sql. Align rule of conversion between numerics#4128

Merged
korlov42 merged 5 commits intoapache:mainfrom
gridgain:ignite-22817
Jul 25, 2024
Merged

IGNITE-22817 Sql. Align rule of conversion between numerics#4128
korlov42 merged 5 commits intoapache:mainfrom
gridgain:ignite-22817

Conversation

@korlov42
Copy link
Copy Markdown
Contributor

https://issues.apache.org/jira/browse/IGNITE-22817


Thank you for submitting the pull request.

To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:

The Review Checklist

  • Formal criteria: TC status, codestyle, mandatory documentation. Also make sure to complete the following:
    - There is a single JIRA ticket related to the pull request.
    - The web-link to the pull request is attached to the JIRA ticket.
    - The JIRA ticket has the Patch Available state.
    - The description of the JIRA ticket explains WHAT was made, WHY and HOW.
    - The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • Design: new code conforms with the design principles of the components it is added to.
  • Patch quality: patch cannot be split into smaller pieces, its size must be reasonable.
  • Code quality: code is clean and readable, necessary developer documentation is added if needed.
  • Tests code quality: test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.

Notes

}

@AfterAll
static void dropTable() {
Copy link
Copy Markdown
Contributor

@ygerzhedovich ygerzhedovich Jul 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure that is scope of the task , but will be better do cleanup in base class for all child like
for (Table t : CLUSTER.aliveNode().tables().tables()) { sql("DROP TABLE " + t.name()); }

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, it doesn't really matter, because we kill the cluster after all tests anyway

- add conversion from NULL
- remove unnecessary overrides in NumericUpdateSourcesCoercionTest
@korlov42 korlov42 merged commit 1d76a1c into apache:main Jul 25, 2024
@korlov42 korlov42 deleted the ignite-22817 branch July 25, 2024 07:44
isapego pushed a commit to isapego/ignite-3 that referenced this pull request Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants