IGNITE-22800 Make field BplusTree#globalRmvId monotonically increasing to avoid errors after node recovery#4131
Conversation
ibessonov
left a comment
ibessonov
left a comment
There was a problem hiding this comment.
Looks good to me. Too many unnecessary renames, but I don't want to argue about that anymore
| public abstract DataRegion<?> dataRegion(); | ||
|
|
||
| /** Returns storage engine for the table. */ | ||
| public abstract AbstractPageMemoryStorageEngine engine(); |
There was a problem hiding this comment.
protected maybe? Why would it be public.
Whatever you decide
There was a problem hiding this comment.
This method is used for example in package org.apache.ignite.internal.storage.pagememory.mv.
| PersistentPageMemoryStorageEngineConfiguration engineConfig, | ||
| @InjectConfiguration("mock.profiles.default = {engine = \"aipersist\"}") | ||
| StorageConfiguration storageConfiguration | ||
| StorageConfiguration storageConfig |
There was a problem hiding this comment.
It's strange that you've shortened this name. What motivated you?
There was a problem hiding this comment.
For consistency in fields configuration naming, previously there was only engineConfig, then they brought storageConfiguration, it confused me a little, I can do it in a separate task.
There was a problem hiding this comment.
I'm fine with it being here
…g to avoid errors after node recovery (apache#4131)
2 participants
https://issues.apache.org/jira/browse/IGNITE-22800
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
The Review Checklist
- There is a single JIRA ticket related to the pull request.
- The web-link to the pull request is attached to the JIRA ticket.
- The JIRA ticket has the Patch Available state.
- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
Notes