IGNITE-15536 Use VarHandle to replace UNSAFE in IgniteSpinReadWriteLock #414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpuch
force-pushed
the
IGNITE-15536
branch
2 times, most recently
from
9ffda81 to
b0a36d2
Compare
sashapolo
reviewed
Oct 27, 2021
modules/core/src/main/java/org/apache/ignite/internal/util/IgniteSpinReadWriteLock.java
Outdated
Show resolved
Hide resolved
modules/core/src/main/java/org/apache/ignite/internal/util/IgniteSpinReadWriteLock.java
Outdated
Show resolved
Hide resolved
modules/core/src/main/java/org/apache/ignite/internal/util/IgniteSpinReadWriteLock.java
Outdated
Show resolved
Hide resolved
modules/core/src/main/java/org/apache/ignite/internal/util/IgniteSpinReadWriteLock.java
Outdated
Show resolved
Hide resolved
modules/core/src/main/java/org/apache/ignite/internal/util/IgniteSpinReadWriteLock.java
Outdated
Show resolved
Hide resolved
modules/core/src/test/java/org/apache/ignite/internal/util/IgniteSpinReadWriteLockTest.java
Show resolved
Hide resolved
modules/core/src/test/java/org/apache/ignite/internal/util/IgniteSpinReadWriteLockTest.java
Outdated
Show resolved
Hide resolved
modules/core/src/test/java/org/apache/ignite/internal/util/IgniteSpinReadWriteLockTest.java
Outdated
Show resolved
Hide resolved
modules/core/src/test/java/org/apache/ignite/internal/util/Poller.java
Outdated
Show resolved
Hide resolved
modules/core/src/test/java/org/apache/ignite/internal/util/Probe.java
Outdated
Show resolved
Hide resolved
Unsafe class is deprecated and not recommended for usage anymore. IgniteSpinReadWriteLock might be switched to VarHandle that theoretically provides same runtime performance, and it's the recommended method to do CAS operations. Also, tests are added and the lock class code is refactored. Co-authored-by: Alexander Polovtcev <alex.polovtcev@gmail.com>
…iteSpinReadWriteLockTest.java Co-authored-by: Alexander Polovtcev <alex.polovtcev@gmail.com>
sashapolo
approved these changes
Oct 28, 2021
Contributor
Author
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsafe class is deprecated and not recommended for usage anymore. IgniteSpinReadWriteLock might be switched to VarHandle that theoretically provides same runtime performance, and it's the recommended method to do CAS operations.
Also, tests are added and the lock class code is refactored.