IGNITE-22981 Relax IgniteClient close exception #4226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptupitsyn
requested changes
Aug 13, 2024
Comment on lines
150
to
156
| if (holders != null) { | ||
| for (ClientChannelHolder hld : holders) { | ||
| hld.close(); | ||
| } | ||
| } | ||
| connMgr.stop(); | ||
| shutdownAndAwaitTermination(streamerFlushExecutor, 10, TimeUnit.SECONDS); |
Contributor
There was a problem hiding this comment.
This is not the same as the old closeAllManually call - we should wrap every close() in a try-catch so that everything is closed even if there was an exception.
We should also do this for holders.
ptupitsyn
approved these changes
Aug 13, 2024
Pochatkin
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-22981