IGNITE-15783 Mapper API and simple implementation. #424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missed types in tests.
# Conflicts: # modules/schema/src/main/java/org/apache/ignite/internal/schema/marshaller/KVMarshaller.java # modules/schema/src/main/java/org/apache/ignite/internal/schema/marshaller/MarshallerUtil.java # modules/schema/src/main/java/org/apache/ignite/internal/schema/marshaller/asm/AsmSerializerGenerator.java # modules/schema/src/main/java/org/apache/ignite/internal/schema/marshaller/reflection/FieldAccessor.java # modules/schema/src/main/java/org/apache/ignite/internal/schema/marshaller/reflection/JavaSerializer.java # modules/schema/src/main/java/org/apache/ignite/internal/schema/marshaller/reflection/Marshaller.java # modules/schema/src/test/java/org/apache/ignite/internal/schema/marshaller/JavaSerializerTest.java # modules/schema/src/test/java/org/apache/ignite/internal/schema/marshaller/reflection/FieldAccessorTest.java # modules/schema/src/test/java/org/apache/ignite/internal/schema/registry/UpgradingRowAdapterTest.java # modules/table/src/main/java/org/apache/ignite/internal/schema/marshaller/KVMarshaller.java # modules/table/src/main/java/org/apache/ignite/internal/schema/marshaller/KvMarshaller.java # modules/table/src/main/java/org/apache/ignite/internal/table/KeyValueViewImpl.java # modules/table/src/test/java/org/apache/ignite/internal/table/KeyValueViewOperationsSimpleSchemaTest.java
AMashenkov
force-pushed
the
ignite-15783
branch
from
857d4b9 to
d83585e
Compare
# Conflicts: # modules/schema/src/main/java/org/apache/ignite/internal/schema/marshaller/asm/ColumnAccessCodeGenerator.java # modules/schema/src/main/java/org/apache/ignite/internal/schema/marshaller/reflection/Marshaller.java # modules/schema/src/test/java/org/apache/ignite/internal/schema/marshaller/JavaSerializerTest.java # modules/schema/src/test/java/org/apache/ignite/internal/schema/marshaller/reflection/FieldAccessorTest.java
modules/api/src/main/java/org/apache/ignite/table/mapper/MapperBuilder.java
Outdated
Show resolved
Hide resolved
| * @param val Object to map to native type. | ||
| * @return {@code null} for {@code null} value. Otherwise returns NativeType according to the value's type. | ||
| */ | ||
| @Contract("null -> null") |
Contributor
There was a problem hiding this comment.
What reason to add jetbrains annotations? I think we should start discussion at least internally before starting it.
Member
Author
There was a problem hiding this comment.
We already use jetbrains annotations in the project (see @Nullable and @NotNull).
The contract is clearly described in javadoc and the annotation just helps to suppress IDEA warning and affect nothing.
Proof:
Note that this annotation just describes how the code works and doesn't add any functionality by means of code generation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-15783