Skip to content

IGNITE-23359 Sql. Additional tests for "out of range" arithmetic operations#4501

Merged
zstan merged 6 commits intoapache:mainfrom
gridgain:ignite-23359
Oct 14, 2024
Merged

IGNITE-23359 Sql. Additional tests for "out of range" arithmetic operations#4501
zstan merged 6 commits intoapache:mainfrom
gridgain:ignite-23359

Conversation

@zstan
Copy link
Contributor

@zstan zstan commented Oct 3, 2024

Thank you for submitting the pull request.

To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:

The Review Checklist

  • Formal criteria: TC status, codestyle, mandatory documentation. Also make sure to complete the following:
    - There is a single JIRA ticket related to the pull request.
    - The web-link to the pull request is attached to the JIRA ticket.
    - The JIRA ticket has the Patch Available state.
    - The description of the JIRA ticket explains WHAT was made, WHY and HOW.
    - The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • Design: new code conforms with the design principles of the components it is added to.
  • Patch quality: patch cannot be split into smaller pieces, its size must be reasonable.
  • Code quality: code is clean and readable, necessary developer documentation is added if needed.
  • Tests code quality: test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.

Notes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's split this test on cast_to_integer with only CAST expressions and integer_arithmetic with arithmetic involving integer types

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename it by analogy with decimal : integer_integer_overflow_cast.test, integer_overflow.test

@zstan zstan requested a review from ygerzhedovich October 9, 2024 13:46
@zstan zstan merged commit 7c06fb3 into apache:main Oct 14, 2024
@zstan zstan deleted the ignite-23359 branch October 14, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants