IGNITE-23335: Sql. Do not store aggregation state in Accumulators #4522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lowka
force-pushed
the
ignite-23335
branch
2 times, most recently
from
9e4e2c6 to
5bdfc3c
Compare
Extract state from AccumulatorWrapper.
...ine/src/main/java/org/apache/ignite/internal/sql/engine/exec/exp/agg/AccumulatorWrapper.java
Show resolved
Hide resolved
...ql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/exp/agg/Accumulators.java
Outdated
Show resolved
Hide resolved
...ql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/exp/agg/Accumulators.java
Outdated
Show resolved
Hide resolved
...ql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/exp/agg/Accumulators.java
Show resolved
Hide resolved
AccumulatorWrapper javadoc
Use named arguments in Sum*AccumulatorTests.
Use mutable holders for long and double.
...sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/exp/agg/MutableLong.java
Outdated
Show resolved
Hide resolved
Remove equals/hashCode from MutableLong.
# Conflicts: # modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/exp/agg/Accumulators.java
ygerzhedovich
approved these changes
Oct 11, 2024
AggregateRow should only store state.
AMashenkov
reviewed
Oct 14, 2024
|
|
||
| acc.accumulator().end(state, result); | ||
|
|
||
| output[i + cardinality] = acc.convertResult(result.get()); |
Member
There was a problem hiding this comment.
Can allFields be replaced with mapping?
i + cardinality can be mapping.get(i)
Or allFields may differ from row to row?
Contributor
Author
There was a problem hiding this comment.
Mapping would make things even more confusing, because there are the following lines at the end of this method.
if (groupId != NO_GROUP_ID && type == AggregateType.MAP) {
output[output.length - 1] = groupId;
}
AMashenkov
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies
AggregateRowby removing all not state related fields from it.Makes
AccumulatorandAccumulatorWrapperstateless.https://issues.apache.org/jira/browse/IGNITE-23335
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
The Review Checklist
- There is a single JIRA ticket related to the pull request.
- The web-link to the pull request is attached to the JIRA ticket.
- The JIRA ticket has the Patch Available state.
- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
Notes