IGNITE-22896 REST API for initiating MG repair#4547
Merged
rpuch merged 6 commits intoapache:mainfrom Oct 15, 2024
Merged
Conversation
rpuch
reviewed
Oct 15, 2024
...i/src/main/java/org/apache/ignite/internal/rest/api/recovery/system/ResetClusterRequest.java
Outdated
Show resolved
Hide resolved
...i/src/main/java/org/apache/ignite/internal/rest/api/recovery/system/ResetClusterRequest.java
Outdated
Show resolved
Hide resolved
...n/java/org/apache/ignite/internal/rest/recovery/system/SystemDisasterRecoveryController.java
Outdated
Show resolved
Hide resolved
.../main/java/org/apache/ignite/internal/disaster/system/SystemDisasterRecoveryManagerImpl.java
Outdated
Show resolved
Hide resolved
rpuch
approved these changes
Oct 15, 2024
AlexLev-Tor
reviewed
Oct 18, 2024
| @Schema(description = "Reset cluster.") | ||
| public class ResetClusterRequest { | ||
| @Schema(description = "Names of the proposed CMG nodes.") | ||
| @Schema(description = "Names of the proposed CMG nodes. Optional if Metastorage replication factor is specified, then " |
Contributor
There was a problem hiding this comment.
I'm not sure what replication factor has to do with it... Re-phrase for clarity... Discuss?
| private final List<String> cmgNodeNames; | ||
| private final @Nullable List<String> cmgNodeNames; | ||
|
|
||
| @Schema(description = "Number of nodes in the Raft voting member set for Metastorage.") |
Contributor
There was a problem hiding this comment.
Number of nodes in the voting member set of the Metastorage RAFT group.
| * Initiates cluster reset. CMG will be reset and Metastorage will be repaired. | ||
| * | ||
| * @param proposedCmgNodeNames Names of the nodes that will be the new CMG nodes. | ||
| * @param proposedCmgNodeNames Names of the nodes that will be the new CMG nodes. If not specified, current CMG nodes will be used. |
Contributor
There was a problem hiding this comment.
Names of the new CMG nodes. If not specified, the current CMG nodes are used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-22896