IGNITE-23484 Do not use ByteUtils#toBytes in zones management #4594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alievmirza
reviewed
Oct 28, 2024
| assertThat(metastore.get(new ByteArray(dataNodeKey[0])).thenApply(Entry::tombstone), willBe(true)); | ||
| } | ||
|
|
||
| private static Map<Node, Integer> deserializeDataNodesMap(byte[] bytes) { |
Contributor
There was a problem hiding this comment.
Why can't we use DistributionZonesUtil#deserializeDataNodesMap? The same with deserializeLogicalTopologySet, I see that you have several copies of this method in different test classes, could we us general method? We could add it to this class as well.
| puts[i++] = put(zoneTopologyAugmentation(zoneId), toBytes(zonesState.get(zoneId).topologyAugmentationMap())); | ||
| puts[i++] = put( | ||
| zoneTopologyAugmentation(zoneId), | ||
| VersionedSerialization.toBytes( |
Contributor
There was a problem hiding this comment.
Constructions like
VersionedSerialization.toBytes(
zonesState.get(zoneId).topologyAugmentationMap(),
TopologyAugmentationMapSerializer.INSTANCE
)
look a bit overloaded.
Maybe, we could hide it inside TopologyAugmentationMapSerializer, so it could look like
TopologyAugmentationMapSerializer.toBytes(zonesState.get(zoneId).topologyAugmentationMap())
?
WDYT? Could this idea be adapted to all Serializers/Deserializers in this PR?
Contributor
Author
There was a problem hiding this comment.
Applied this approach where it makes sense
alievmirza
approved these changes
Oct 28, 2024
| : "Initial value of nodes' attributes was changed after initialization from the Meta Storage manager."; | ||
| } | ||
|
|
||
| private static Map<UUID, NodeWithAttributes> deserializeNodesAttributes(byte[] bytes) { |
Contributor
There was a problem hiding this comment.
lets place it in DistributionZonesUtil as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-23484