IGNITE-23615 Use shared threadpools in RocksDbFlusher for RocksDbKeyValueStorage#4713
Merged
tkalkirill merged 8 commits intoapache:mainfrom Nov 14, 2024
Merged
IGNITE-23615 Use shared threadpools in RocksDbFlusher for RocksDbKeyValueStorage#4713tkalkirill merged 8 commits intoapache:mainfrom
tkalkirill merged 8 commits intoapache:mainfrom
Conversation
tkalkirill
changed the title
rpuch
reviewed
Nov 13, 2024
...ore/src/test/java/org/apache/ignite/internal/testframework/ExecutorServiceExtensionTest.java
Outdated
Show resolved
Hide resolved
...ore/src/test/java/org/apache/ignite/internal/testframework/ExecutorServiceExtensionTest.java
Outdated
Show resolved
Hide resolved
...ore/src/test/java/org/apache/ignite/internal/testframework/ExecutorServiceExtensionTest.java
Outdated
Show resolved
Hide resolved
...ore/src/test/java/org/apache/ignite/internal/testframework/ExecutorServiceExtensionTest.java
Outdated
Show resolved
Hide resolved
...ore/src/test/java/org/apache/ignite/internal/testframework/ExecutorServiceExtensionTest.java
Outdated
Show resolved
Hide resolved
...src/testFixtures/java/org/apache/ignite/internal/testframework/ExecutorServiceExtension.java
Outdated
Show resolved
Hide resolved
|
|
||
| assert injectExecutorService != null : field; | ||
|
|
||
| return createExecutorService(injectExecutorService, field.getName(), field.getType(), field.getDeclaringClass()); |
Contributor
There was a problem hiding this comment.
If a field is declared in a superclass, then field.getDeclaringClass() will not be the actual test class. It will then be used to get logger, for example. Is this intended?
Contributor
Author
There was a problem hiding this comment.
Yes, do you have any suggestions?
Contributor
There was a problem hiding this comment.
Well, I asked a question :) What is already in code makes some sense already. Or we could use the real test class to obtain a logger. Up to you to decide.
...src/testFixtures/java/org/apache/ignite/internal/testframework/ExecutorServiceExtension.java
Outdated
Show resolved
Hide resolved
...n/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java
Show resolved
Hide resolved
modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java
Show resolved
Hide resolved
rpuch
approved these changes
Nov 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-23615