IGNITE-23379 Pass lease information with Raft snapshot of partition#4725
Merged
rpuch merged 13 commits intoapache:mainfrom Nov 15, 2024
Merged
IGNITE-23379 Pass lease information with Raft snapshot of partition#4725rpuch merged 13 commits intoapache:mainfrom
rpuch merged 13 commits intoapache:mainfrom
Conversation
tkalkirill
reviewed
Nov 15, 2024
...java/org/apache/ignite/internal/partition/replicator/network/raft/PartitionSnapshotMeta.java
Show resolved
Hide resolved
...rage-api/src/main/java/org/apache/ignite/internal/storage/engine/PrimitivePartitionMeta.java
Show resolved
Hide resolved
...rage-api/src/main/java/org/apache/ignite/internal/storage/engine/PrimitivePartitionMeta.java
Show resolved
Hide resolved
...ge-api/src/testFixtures/java/org/apache/ignite/internal/storage/impl/TestMvTableStorage.java
Show resolved
Hide resolved
...ge-api/src/testFixtures/java/org/apache/ignite/internal/storage/impl/TestMvTableStorage.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/ignite/internal/table/distributed/raft/snapshot/PartitionAccess.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/ignite/internal/table/distributed/raft/snapshot/PartitionAccess.java
Outdated
Show resolved
Hide resolved
...c/integrationTest/java/org/apache/ignite/internal/raftsnapshot/ItTableRaftSnapshotsTest.java
Outdated
Show resolved
Hide resolved
...c/integrationTest/java/org/apache/ignite/internal/raftsnapshot/ItTableRaftSnapshotsTest.java
Outdated
Show resolved
Hide resolved
| outputStream.write(primaryReplicaNodeIdBytes); | ||
| private void saveLease(AbstractWriteBatch writeBatch, long leaseStartTime, UUID primaryReplicaNodeId, String primaryReplicaNodeName) { | ||
| try { | ||
| ByteArrayOutputStream outputStream = new ByteArrayOutputStream(); |
Contributor
There was a problem hiding this comment.
Maybe make the meta serializable and write the serialization logic to it?
Contributor
Author
There was a problem hiding this comment.
Please note that in this case only lease information is updated, not the whole partition metadata.
I like the idea to make this format versioned, filed an issue https://issues.apache.org/jira/browse/IGNITE-23683
tkalkirill
approved these changes
Nov 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-23379