IGNITE-23701 Add output of execution duration LogSyncer to message "Checkpoint finished"#4744
Merged
tkalkirill merged 2 commits intoapache:mainfrom Nov 19, 2024
Merged
Conversation
rpuch
approved these changes
Nov 19, 2024
...a/org/apache/ignite/internal/pagememory/persistence/checkpoint/CheckpointMetricsTracker.java
Outdated
Show resolved
Hide resolved
...a/org/apache/ignite/internal/pagememory/persistence/checkpoint/CheckpointMetricsTracker.java
Outdated
Show resolved
Hide resolved
|
|
||
| private void syncWal(CheckpointMetricsTracker tracker) throws IgniteInternalCheckedException { | ||
| try { | ||
| tracker.onSyncWalStart(); |
Contributor
There was a problem hiding this comment.
In Ignite 2, the log was a WAL and this term was used in the whole codebase. In Ignite 3, we usually talk about Raft log (or simply log) and not a WAL. Maybe it will be more consistent to use 'log' term instead of 'WAL' in this class as well.
rpuch
approved these changes
Nov 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-23701