IGNITE-23708 testAutomaticRebalanceIfMajorityIsLost is flaky#4747
Merged
sanpwc merged 5 commits intoapache:mainfrom Nov 22, 2024
Merged
IGNITE-23708 testAutomaticRebalanceIfMajorityIsLost is flaky#4747sanpwc merged 5 commits intoapache:mainfrom
sanpwc merged 5 commits intoapache:mainfrom
Conversation
sanpwc
changed the title
# Conflicts: # modules/table/src/main/java/org/apache/ignite/internal/table/distributed/disaster/GroupUpdateRequest.java
JAkutenshi
force-pushed
the
ignite-23708
branch
from
b366bfe to
d31353b
Compare
sanpwc
reviewed
Nov 22, 2024
.../src/main/java/org/apache/ignite/internal/table/distributed/disaster/GroupUpdateRequest.java
Outdated
Show resolved
Hide resolved
sanpwc
reviewed
Nov 22, 2024
.../src/main/java/org/apache/ignite/internal/table/distributed/disaster/GroupUpdateRequest.java
Outdated
Show resolved
Hide resolved
sanpwc
reviewed
Nov 22, 2024
.../src/main/java/org/apache/ignite/internal/table/distributed/disaster/GroupUpdateRequest.java
Outdated
Show resolved
Hide resolved
sanpwc
approved these changes
Nov 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA Ticket: IGNITE-23708
The goal
The main goal of the PR is to fix
testAutomaticRebalanceIfMajorityIsLost:assertRealAssignments(node0, partId, 1)especially after IGNITE-22036 changes.[1]. This leads also to a flacky non-null result onassertNull(getPendingAssignments(node0, partId))check.The reason
Tests shouldn't be flacky and flawed implementation should be fixed.
The solution
assertRealAssignments's timeout is increased up to 5s.GroupUpdateRequest#partitionUpdateif there are alive nodes we have equalpartandstableassignments we shouldn't schedule the redundant rebalance and then should put justnullthen.