Skip to content

IGNITE-23704: Incorrect equal implementation in TemporalNativeType and VarlenNativeType#4748

Merged
AMashenkov merged 1 commit intoapache:mainfrom
gridgain:ignite-23704
Nov 25, 2024
Merged

IGNITE-23704: Incorrect equal implementation in TemporalNativeType and VarlenNativeType#4748
AMashenkov merged 1 commit intoapache:mainfrom
gridgain:ignite-23704

Conversation

@lowka
Copy link
Copy Markdown
Contributor

@lowka lowka commented Nov 19, 2024

Fixes equals method of TemporalNativeType and VarlenNativeType .

https://issues.apache.org/jira/browse/IGNITE-23704


Thank you for submitting the pull request.

To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:

The Review Checklist

  • Formal criteria: TC status, codestyle, mandatory documentation. Also make sure to complete the following:
    - There is a single JIRA ticket related to the pull request.
    - The web-link to the pull request is attached to the JIRA ticket.
    - The JIRA ticket has the Patch Available state.
    - The description of the JIRA ticket explains WHAT was made, WHY and HOW.
    - The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • Design: new code conforms with the design principles of the components it is added to.
  • Patch quality: patch cannot be split into smaller pieces, its size must be reasonable.
  • Code quality: code is clean and readable, necessary developer documentation is added if needed.
  • Tests code quality: test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.

Notes

@lowka lowka force-pushed the ignite-23704 branch 2 times, most recently from 29645b2 to f7c5edc Compare November 20, 2024 08:28
@AMashenkov AMashenkov merged commit bf8b4d0 into apache:main Nov 25, 2024
@AMashenkov AMashenkov deleted the ignite-23704 branch November 25, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants