Skip to content

IGNITE-23982 Comment out asserts on primary elected/expired in ReplicaStateManager #4893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sanpwc merged 1 commit into from
Dec 13, 2024
Merged

IGNITE-23982 Comment out asserts on primary elected/expired in ReplicaStateManager #4893

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1367,8 +1367,9 @@ private void registerFailoverCallback(ReplicationGroupId replicationGroupId) {
return;
}

assert replicaFuture.isDone() : "Illegal state: replica future exists and elected as primary, but the future isn't completed"
+ " [replicationGroupId=" + replicaFuture + "].";
// TODO: https://issues.apache.org/jira/browse/IGNITE-23981
// assert replicaFuture.isDone() : "Illegal state: replica future exists and elected as primary, but the future isn't completed"
// + " [replicationGroupId=" + replicaFuture + "].";

replicaFuture.thenCompose(inBusyLock(busyLock, () -> (Function<Replica, CompletableFuture<Void>>) electedPrimaryReplica -> {
onLeaderElectedFailoverCallback = (leaderNode, term) -> changePeersAndLearnersAsyncIfPendingExists(
Expand Down Expand Up @@ -1398,8 +1399,9 @@ private void unregisterFailoverCallback(PrimaryReplicaEventParameters parameters
return;
}

assert replicaFuture.isDone() : "Illegal state: replica future exists and was elected as primary, but the future isn't"
+ " completed [replicationGroupId=" + replicaFuture + "].";
// TODO: https://issues.apache.org/jira/browse/IGNITE-23981
// assert replicaFuture.isDone() : "Illegal state: replica future exists and was elected as primary, but the future isn't"
// + " completed [replicationGroupId=" + replicaFuture + "].";

replicaFuture.thenAccept(inBusyLock(busyLock, () -> (Consumer<Replica>) expiredPrimaryReplica -> expiredPrimaryReplica
.raftClient()
Expand Down