IGNITE-15721 Implemented the ability to use configuration instances as direct proxies to underlying storages. #499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s direct proxies to underlying storages. Signed-off-by: ibessonov <bessonov.ip@gmail.com>
sashapolo
reviewed
Dec 9, 2021
| .addModifiers(PUBLIC); | ||
|
|
||
| for (VariableElement field : fields) { | ||
| if (field.getModifiers().contains(STATIC)) { |
Contributor
There was a problem hiding this comment.
I think that fields method already returns only non-static members
sashapolo
reviewed
Dec 9, 2021
| } | ||
| } | ||
| } catch (Throwable t) { | ||
| assert false; |
Contributor
Author
There was a problem hiding this comment.
I guess that was the reminder for myself. That exception handling is a complete nonsense.
Signed-off-by: ibessonov <bessonov.ip@gmail.com>
Signed-off-by: ibessonov <bessonov.ip@gmail.com>
Signed-off-by: ibessonov <bessonov.ip@gmail.com>
Signed-off-by: ibessonov <bessonov.ip@gmail.com>
Signed-off-by: ibessonov <bessonov.ip@gmail.com>
Signed-off-by: ibessonov <bessonov.ip@gmail.com>
SammyVimes
requested changes
Dec 21, 2021
.../configuration/src/main/java/org/apache/ignite/internal/configuration/ConfigurationNode.java
Outdated
Show resolved
Hide resolved
...es/configuration/src/main/java/org/apache/ignite/internal/configuration/DynamicProperty.java
Show resolved
Hide resolved
...es/configuration/src/main/java/org/apache/ignite/internal/configuration/DynamicProperty.java
Show resolved
Hide resolved
...tion/src/main/java/org/apache/ignite/internal/configuration/asm/DirectProxyAsmGenerator.java
Show resolved
Hide resolved
...tion/src/main/java/org/apache/ignite/internal/configuration/asm/DirectProxyAsmGenerator.java
Show resolved
Hide resolved
...iguration/src/main/java/org/apache/ignite/internal/configuration/util/ConfigurationUtil.java
Outdated
Show resolved
Hide resolved
SammyVimes
approved these changes
Dec 22, 2021
Contributor
|
Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-15721