IGNITE-24055 Sql. Update the observation timestamp only after processing DDL statements#5032
Merged
xtern merged 9 commits intoapache:mainfrom Jan 21, 2025
Merged
IGNITE-24055 Sql. Update the observation timestamp only after processing DDL statements#5032xtern merged 9 commits intoapache:mainfrom
xtern merged 9 commits intoapache:mainfrom
Conversation
xtern
force-pushed
the
ignite-24055
branch
2 times, most recently
from
d97d706 to
f28840a
Compare
xtern
changed the title
korlov42
reviewed
Jan 17, 2025
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/commands/CatalogUtils.java
Show resolved
Hide resolved
...l-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ddl/DdlCommandHandler.java
Outdated
Show resolved
Hide resolved
...-engine/src/test/java/org/apache/ignite/internal/sql/engine/framework/ImplicitTxContext.java
Outdated
Show resolved
Hide resolved
korlov42
approved these changes
Jan 17, 2025
vldpyatkov
approved these changes
Jan 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-24055
CatalogUtils.clusterWideEnsuredActivationTsSafeForRoReads. Otherwise these changes seem useless. The description of IGNITE-20378 looks outdated because it is about different clients, but at the moment the concept has changed and we guarantee the visibility of changes only within one client instance.testClientPropagatesLatestKnownHybridTimestamp(fromObservableTimestampPropagationTest) has been trimmed since the observable time is now updated inside the query execution, and an additional testddlExecutionUpdatesObservableTime(ExecutionServiceImplTest) has been added to verify this.