IGNITE-23769 Compute job cancel race#5095
Merged
Pochatkin merged 4 commits intoapache:mainfrom Jan 24, 2025
Merged
Conversation
zstan
approved these changes
Jan 23, 2025
Pochatkin
approved these changes
Jan 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-23769
This fixes the specific race when job status was
QUEUEDat the time ofstateMachine.cancelingJobcall but the job was already removed from the work queue.In this case
cancelingJobwill change the status toCANCELEDbut thestateMachine.executeJobwill still be called causing theIllegalJobStatusTransitionexception.To fix this, make both calls under the lock and check the state before transition. In case this state is detected, don't transition the status and don't run the job, return
nullfrom the job and check this state again at the final step, completing the result future with theCancellationException.