Skip to content

IGNITE-22405: Sql. Implement log10 function based on java Math.log10 implementation#5165

Merged
korlov42 merged 1 commit intoapache:mainfrom
gridgain:ignite-22405
Feb 5, 2025
Merged

IGNITE-22405: Sql. Implement log10 function based on java Math.log10 implementation#5165
korlov42 merged 1 commit intoapache:mainfrom
gridgain:ignite-22405

Conversation

@lowka
Copy link
Copy Markdown
Contributor

@lowka lowka commented Feb 4, 2025

https://issues.apache.org/jira/browse/IGNITE-22405


Thank you for submitting the pull request.

To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:

The Review Checklist

  • Formal criteria: TC status, codestyle, mandatory documentation. Also make sure to complete the following:
    - There is a single JIRA ticket related to the pull request.
    - The web-link to the pull request is attached to the JIRA ticket.
    - The JIRA ticket has the Patch Available state.
    - The description of the JIRA ticket explains WHAT was made, WHY and HOW.
    - The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • Design: new code conforms with the design principles of the components it is added to.
  • Patch quality: patch cannot be split into smaller pieces, its size must be reasonable.
  • Code quality: code is clean and readable, necessary developer documentation is added if needed.
  • Tests code quality: test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.

Notes

@lowka lowka marked this pull request as ready for review February 4, 2025 14:30
@korlov42 korlov42 merged commit 7d8e87d into apache:main Feb 5, 2025
@korlov42 korlov42 deleted the ignite-22405 branch February 5, 2025 17:18
zstan pushed a commit to gridgain/apache-ignite-3 that referenced this pull request Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants