[IGNITE-23326] Configuration parser allows duplicated keys#5166
Merged
rpuch merged 9 commits intoapache:mainfrom Feb 6, 2025
Merged
[IGNITE-23326] Configuration parser allows duplicated keys#5166rpuch merged 9 commits intoapache:mainfrom
rpuch merged 9 commits intoapache:mainfrom
Conversation
Phillippko
commented
Feb 4, 2025
| void close(); | ||
|
|
||
| /** Validate that there are no duplicates in the stored configuration. */ | ||
| default Collection<ValidationIssue> validateDuplicates() { |
Contributor
Author
There was a problem hiding this comment.
Not sure about this, maybe we should validate duplicates in in LocalFileConfigurationStorage.readDataOnRecovery. But then user won't receive other validation issues until duplicated keys are removed
Contributor
There was a problem hiding this comment.
Validation method doesn't seem to belong to a 'storage' abstraction. I suggest moving it elsewhere
rpuch
reviewed
Feb 5, 2025
| void close(); | ||
|
|
||
| /** Validate that there are no duplicates in the stored configuration. */ | ||
| default Collection<ValidationIssue> validateDuplicates() { |
Contributor
There was a problem hiding this comment.
Validation method doesn't seem to belong to a 'storage' abstraction. I suggest moving it elsewhere
...va/org/apache/ignite/internal/configuration/validation/ConfigurationDuplicatesValidator.java
Outdated
Show resolved
Hide resolved
...va/org/apache/ignite/internal/configuration/validation/ConfigurationDuplicatesValidator.java
Outdated
Show resolved
Hide resolved
...va/org/apache/ignite/internal/configuration/validation/ConfigurationDuplicatesValidator.java
Outdated
Show resolved
Hide resolved
...va/org/apache/ignite/internal/configuration/validation/ConfigurationDuplicatesValidator.java
Outdated
Show resolved
Hide resolved
...va/org/apache/ignite/internal/configuration/validation/ConfigurationDuplicatesValidator.java
Outdated
Show resolved
Hide resolved
...rg/apache/ignite/internal/configuration/validation/ConfigurationDuplicatesValidatorTest.java
Outdated
Show resolved
Hide resolved
rpuch
approved these changes
Feb 6, 2025
| public ConfigurationValidationException(Collection<ValidationIssue> issues) { | ||
| super(createMessageFromIssues(issues)); | ||
|
|
||
| this.issues = issues; |
Contributor
There was a problem hiding this comment.
Let's make a defensive copy, by the way
| } | ||
|
|
||
| private static String path(Object firstChild) { | ||
| /** Return full path to the given node. Elements of array don't have a NodePath child, so index is used instead. */ |
Contributor
There was a problem hiding this comment.
Suggested change
| /** Return full path to the given node. Elements of array don't have a NodePath child, so index is used instead. */ | |
| /** Returns full path to the given node. Elements of array don't have a NodePath child, so index is used instead. */ |
rpuch
approved these changes
Feb 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-23326