Skip to content

IGNITE-16121 Thin client: Implement KeyValueView #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ptupitsyn merged 55 commits into from
Dec 22, 2021
Merged

IGNITE-16121 Thin client: Implement KeyValueView #517

ptupitsyn merged 55 commits into from
Dec 22, 2021

Conversation

@ptupitsyn
Copy link
Contributor

@ptupitsyn ptupitsyn commented Dec 21, 2021 •
edited
Loading

  • Extract record serialization logic into ClientRecordSerializer.
  • Implement KeyValueView in thin client.

@ptupitsyn
IGNITE-16121 Thin 3.0: Implement KeyValueView with POJO mapping
4b87a3f 
Extract record serialization into ClientRecordSerializer
@ptupitsyn
wip ClientRecordSerializer
7883d7d
@ptupitsyn
Add ClientKeyValueView
1b7e1d1
@ptupitsyn
wip ClientKeyValueView
36fe051
@ptupitsyn
wip ClientKeyValueViewTest
f6c484a
@ptupitsyn
testBinaryPutPrimitiveGet
33d117a
@ptupitsyn
wip tests
5ff63bb
@ptupitsyn
Improve exception text for column mismatch
f3c8e84
@ptupitsyn
Add testColumnTypeMismatchThrowsException
355964b
@ptupitsyn
wip tests
e443ab8
@ptupitsyn
testPrimitivePutBinaryGet fixed
dbc875c
@ptupitsyn
testMissingValueColumnsAreSkipped
4706ebf
@ptupitsyn
testAllColumnsBinaryPutPojoGet
6f3bb8e
@ptupitsyn
testAllColumnsPojoPutBinaryGet
51e607d
@ptupitsyn
testMissingKeyColumnThrowsException
c0f2a7f
@ptupitsyn
testNullablePrimitiveFields
d50c494
@ptupitsyn
wip testGetAll
47ad1d0
@ptupitsyn
wip getAllAsync
612b044
@ptupitsyn
wip getAllAsync
14562c1
@ptupitsyn
wip testGetAll
d6af25a
@ptupitsyn
testGetAll works - use LinkedHashMap to preserve order
69eb8ac
@ptupitsyn
testGetAllPrimitive
29c0263
@ptupitsyn
wip testPutAll
ba9d5cf
@ptupitsyn
testPutAll done
ee4e0c0
@ptupitsyn
wip testGetAndPut
1218e66
@ptupitsyn
testGetAndPut done
972e8af
@ptupitsyn
wip putIfAbsentAsync
3877a3d
@ptupitsyn
Fix javadoc
48461e4
@ptupitsyn
Fix code style
5979c78
@ptupitsyn
Add testPutNull
295fa57
@ptupitsyn ptupitsyn self-assigned this Dec 21, 2021
@ptupitsyn ptupitsyn requested a review from AMashenkov December 21, 2021 07:17
isapego
isapego approved these changes Dec 21, 2021
View reviewed changes
Copy link
Contributor

@isapego isapego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

modules/client/src/main/java/org/apache/ignite/internal/client/table/ClientKeyValueView.java

/** {@inheritDoc} */
@Override
public @NotNull CompletableFuture<V> getAsync(@Nullable Transaction tx, @NotNull K key) {
Copy link
Contributor

@isapego isapego Dec 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add check and throw "not supported" exception if tx is not null

Copy link
Contributor Author

@ptupitsyn ptupitsyn Dec 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@ptupitsyn ptupitsyn merged commit 21e9cd8 into apache:main Dec 22, 2021
@ptupitsyn ptupitsyn deleted the ignite-16121 branch December 22, 2021 07:22
ygerzhedovich pushed a commit that referenced this pull request Feb 23, 2024
@valepakh
GG-38343 Implement job ownership (#517)
bbb3b10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AMashenkov AMashenkov AMashenkov approved these changes

@isapego isapego isapego approved these changes

Assignees

@ptupitsyn ptupitsyn

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ptupitsyn @AMashenkov @isapego