Merged
Conversation
alievmirza
reviewed
Feb 10, 2025
| int tableId = getTableId(node.catalogManager(), HA_TABLE_NAME, clock.nowLong()); | ||
|
|
||
| for (Integer partId : PARTITION_IDS) { | ||
| assertRaftGroupsOnNodes(node, partId, tableId, HA_ZONE_NAME, 0, 1, 2, 3); |
Contributor
There was a problem hiding this comment.
AFAIK, this is "Verify that the partition is rebalanced to include node D" step.
Why can't we just check that D is in stable?
alievmirza
approved these changes
Feb 11, 2025
alievmirza
suggested changes
Feb 11, 2025
|
|
||
| executeSql(format("ALTER ZONE %s SET data_nodes_auto_adjust_scale_down=%d", HA_ZONE_NAME, 1)); | ||
|
|
||
| waitAndAssertStableAssignmentsOfPartitionEqualTo(node, HA_TABLE_NAME, PARTITION_IDS, threeNodes); |
Contributor
There was a problem hiding this comment.
let's add
Verify that the data is consistent across all nodes (A, B, C, D).
as it presented in the doc, using table.internalTable().get(key, clock.now(), recipientNode)
alievmirza
reviewed
Feb 11, 2025
| return errors; | ||
| } | ||
|
|
||
| static void assertValuesPresent(Table table) { |
| CompletableFuture<Void> insertFuture = keyValueView.putAsync(null, key, Tuple.create(of("val", i + offset))); | ||
|
|
||
| try { | ||
| insertFuture.get(10, SECONDS); |
Contributor
There was a problem hiding this comment.
let's use assertThat(fut, willCompleteSuccessfully()); approach here
| } | ||
|
|
||
| private static boolean isPrimaryReplicaHasChangedException(IgniteException cause) { | ||
| return cause.getMessage() != null && cause.getMessage().contains("The primary replica has changed"); |
Contributor
There was a problem hiding this comment.
What if sb change message? Can't we check instanceof, or error code, for example?
alievmirza
reviewed
Feb 11, 2025
| }); | ||
| } | ||
|
|
||
| void assertValuesPresentOnNodes(IgniteImpl node, Table table, Integer... indexes) { |
Contributor
There was a problem hiding this comment.
let's pass ts here instead of node.
alievmirza
approved these changes
Feb 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-24413