IGNITE-24643 Lower logging level for 'Peer id not found' in Replicator#5299
IGNITE-24643 Lower logging level for 'Peer id not found' in Replicator#5299rpuch merged 4 commits intoapache:mainfrom
Conversation
| } | ||
| } | ||
|
|
||
| private static void logFailToIssueRpc(Status status, Replicator r) { |
There was a problem hiding this comment.
Let's name it replicator :)
There was a problem hiding this comment.
P.S. quite to be honest PMD rule to prevent single symbol names is a good one and we shall consider enable it ;)
There was a problem hiding this comment.
This is JRaft code (not ours), we try to touch it as little as possible, so the checks (checkstyle/PMD/whatever) are disabled in this module
|
|
||
| private static void logFailToIssueRpc(Status status, Replicator r) { | ||
| if (status.getRaftError() == RaftError.ENOENT) { | ||
| // Maybe the target node was not able to start yet, no need to WARN here. |
There was a problem hiding this comment.
Can we move it to javaDoc?
There was a problem hiding this comment.
I doubt it's needed there. Javadoc is about method interface, but here it's an implementation detail
There was a problem hiding this comment.
It can contain implementation details, especially for private methods.
At least at will be nicer to read what is going on and we need to branch.
modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/Replicator.java
Outdated
Show resolved
Hide resolved
| LOG.info("Fail to issue RPC to {}, consecutiveErrorTimes={}, error={}", peerId, | ||
| consecutiveErrorTimes, status); |
There was a problem hiding this comment.
| LOG.info("Fail to issue RPC to {}, consecutiveErrorTimes={}, error={}", peerId, | |
| consecutiveErrorTimes, status); | |
| LOG.info("Fail to issue RPC to {}, consecutiveErrorTimes={}, error={}", peerId, consecutiveErrorTimes, status); |
There was a problem hiding this comment.
Now it nicely fits into one line ;)
| LOG.warn("Fail to issue RPC to {}, consecutiveErrorTimes={}, error={}", peerId, | ||
| consecutiveErrorTimes, status); |
There was a problem hiding this comment.
| LOG.warn("Fail to issue RPC to {}, consecutiveErrorTimes={}, error={}", peerId, | |
| consecutiveErrorTimes, status); | |
| LOG.warn("Fail to issue RPC to {}, consecutiveErrorTimes={}, error={}", peerId, consecutiveErrorTimes, status); |
2 participants
https://issues.apache.org/jira/browse/IGNITE-24643