IGNITE-16081 Compute PoC #534
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpuch
reviewed
Jan 10, 2022
Contributor
rpuch
left a comment
rpuch
left a comment
There was a problem hiding this comment.
A general consideration, our favorite: what happens if a node that initiated a computation leaves the cluster? Will the computation be abandoned?
modules/api/src/main/java/org/apache/ignite/compute/ComputeTask.java
Outdated
Show resolved
Hide resolved
modules/api/src/main/java/org/apache/ignite/compute/IgniteCompute.java
Outdated
Show resolved
Hide resolved
modules/api/src/main/java/org/apache/ignite/compute/IgniteCompute.java
Outdated
Show resolved
Hide resolved
modules/client/src/main/java/org/apache/ignite/internal/client/TcpIgniteClient.java
Show resolved
Hide resolved
modules/compute/src/main/java/org/apache/ignite/compute/internal/IgniteComputeImpl.java
Show resolved
Hide resolved
modules/compute/src/main/java/org/apache/ignite/compute/internal/IgniteComputeImpl.java
Outdated
Show resolved
Hide resolved
modules/compute/src/main/java/org/apache/ignite/compute/internal/IgniteComputeImpl.java
Show resolved
Hide resolved
modules/compute/src/test/java/org/apache/ignite/compute/internal/IgniteComputeImplTest.java
Outdated
Show resolved
Hide resolved
.../org/apache/ignite/internal/network/processor/serialization/MessageReaderMethodResolver.java
Show resolved
Hide resolved
SammyVimes
force-pushed
the
ignite-16081
branch
from
f3f4a61 to
f89fabe
Compare
rpuch
approved these changes
Jan 10, 2022
SammyVimes
force-pushed
the
ignite-16081
branch
from
dbe1146 to
e6d36e2
Compare
AMashenkov
reviewed
Feb 4, 2022
modules/api/src/main/java/org/apache/ignite/compute/ComputeException.java
Outdated
Show resolved
Hide resolved
AMashenkov
reviewed
Feb 4, 2022
Comment on lines
24
to
26
| * handles splitting business logic into multiple jobs, receiving | ||
| * results from individual jobs executing on remote nodes, and reducing | ||
| * (aggregating) received jobs' results into final compute task result. |
Member
There was a problem hiding this comment.
In Ignite 2 we had a ComputeTask and ComputeJob.
What does the term 'job' means here?
Let's clarify here if the 'job' is also represented with an object of ComputeTask kind.
Contributor
Author
There was a problem hiding this comment.
I've updated the javadoc, please, have a look
SammyVimes
force-pushed
the
ignite-16081
branch
from
e6d36e2 to
d67b44a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-16081