Skip to content

IGNITE-24898 Fixed broken serialization in table views when a column is mapped to a primitive field using TypeConverter#5660

Merged
AMashenkov merged 1 commit into
mainfrom
ignite-24898
Apr 23, 2025
Merged

IGNITE-24898 Fixed broken serialization in table views when a column is mapped to a primitive field using TypeConverter#5660
AMashenkov merged 1 commit into
mainfrom
ignite-24898

Conversation

@AMashenkov
Copy link
Copy Markdown
Member

Thank you for submitting the pull request.

To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:

The Review Checklist

  • Formal criteria: TC status, codestyle, mandatory documentation. Also make sure to complete the following:
    - There is a single JIRA ticket related to the pull request.
    - The web-link to the pull request is attached to the JIRA ticket.
    - The JIRA ticket has the Patch Available state.
    - The description of the JIRA ticket explains WHAT was made, WHY and HOW.
    - The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • Design: new code conforms with the design principles of the components it is added to.
  • Patch quality: patch cannot be split into smaller pieces, its size must be reasonable.
  • Code quality: code is clean and readable, necessary developer documentation is added if needed.
  • Tests code quality: test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.

Notes

@AMashenkov AMashenkov requested a review from Copilot April 17, 2025 12:46
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

modules/marshaller-common/src/main/java/org/apache/ignite/internal/marshaller/FieldAccessor.java:83

  • The optimization branch for primitive types only handles the P_DOUBLE case. If other primitive types (e.g., INT, BOOLEAN, etc.) are expected to be optimized similarly, please add corresponding cases or clarify the intended behavior.
BinaryMode fieldAccessMode = BinaryMode.forClass(field.getType());

@AMashenkov AMashenkov merged commit 5f1ef00 into main Apr 23, 2025
1 check passed
@AMashenkov AMashenkov deleted the ignite-24898 branch March 18, 2026 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants