-
Notifications
You must be signed in to change notification settings - Fork 133
IGNITE-27346 Handle 'LWM below earliest Catalog ts' on recovery #7326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…very A few components access Catalog by the stored LWM on node recovery. LWM is the local property of the node, while Catalog history might be compacted by other nodes, so local LWM might point at a moment of time at which the Catalog history is already compacted out. To avoid failing in such situations, we take max(lwm, earliestCatalogTs) on recovery to access the Catalog history.
sashapolo
reviewed
Dec 29, 2025
...tor/src/main/java/org/apache/ignite/internal/partition/replicator/SafeLowWatermarkUtils.java
Show resolved
Hide resolved
sashapolo
reviewed
Dec 29, 2025
...tor/src/main/java/org/apache/ignite/internal/partition/replicator/SafeLowWatermarkUtils.java
Outdated
Show resolved
Hide resolved
...tor/src/main/java/org/apache/ignite/internal/partition/replicator/SafeLowWatermarkUtils.java
Outdated
Show resolved
Hide resolved
...tor/src/main/java/org/apache/ignite/internal/partition/replicator/SafeLowWatermarkUtils.java
Outdated
Show resolved
Hide resolved
...gnite/internal/catalog/compaction/ItNodeRecoveryAfterCatalogTruncatedAboveStoredLwmTest.java
Outdated
Show resolved
Hide resolved
...gnite/internal/catalog/compaction/ItNodeRecoveryAfterCatalogTruncatedAboveStoredLwmTest.java
Outdated
Show resolved
Hide resolved
...gnite/internal/catalog/compaction/ItNodeRecoveryAfterCatalogTruncatedAboveStoredLwmTest.java
Show resolved
Hide resolved
...gnite/internal/catalog/compaction/ItNodeRecoveryAfterCatalogTruncatedAboveStoredLwmTest.java
Outdated
Show resolved
Hide resolved
sashapolo
approved these changes
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few components access Catalog by the stored LWM on node recovery. LWM is the local property of the node, while Catalog history might be compacted by other nodes, so local LWM might point at a moment of time at which the Catalog history is already compacted out. To avoid failing in such situations, we take max(lwm, earliestCatalogTs) on recovery to access the Catalog history.
https://issues.apache.org/jira/browse/IGNITE-27346