IGNITE-16719. #738
Merged
IGNITE-16719. #738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tledkov
reviewed
Mar 21, 2022
|
|
||
| private AtomicInteger scanCounter = new AtomicInteger(1); | ||
|
|
||
| private static final int INTERNAL_BATCH_SIZE = 10_000; |
There was a problem hiding this comment.
Should we use configured parameter to define internal batch size?
Contributor
Author
There was a problem hiding this comment.
naa, not now, and I'd rather use dynamic calculation here.
tledkov
reviewed
Mar 21, 2022
| retrievedItems.add(item); | ||
|
|
||
| if (retrievedItems.size() % reqAmount == 0) { | ||
| if (reqAmount != Long.MAX_VALUE && retrievedItems.size() % reqAmount == 0) { |
There was a problem hiding this comment.
What for additional condition reqAmount != Long.MAX_VALUE is added?
Is the condition retrievedItems.size() % reqAmount true in this case?
Contributor
Author
There was a problem hiding this comment.
Yep, it's possible to remove given check here. Fixed.
korlov42
approved these changes
Mar 23, 2022
...le/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java
Outdated
Show resolved
Hide resolved
…istributed/storage/InternalTableImpl.java Co-authored-by: korlov42 <korlov@gridgain.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.