IGNITE-16221 Thin 3.0: Add RetryPolicy#761
Merged
ptupitsyn merged 62 commits intoapache:mainfrom Apr 5, 2022
Merged
Conversation
# Conflicts: # modules/client/src/test/java/org/apache/ignite/client/fakes/FakeIgniteTables.java
isapego
approved these changes
Apr 5, 2022
Contributor
isapego
left a comment
isapego
left a comment
There was a problem hiding this comment.
Looks good overall. Left a single comment
| private final long heartbeatInterval; | ||
|
|
||
| /** Retry policy. */ | ||
| private final RetryPolicy retryPolicy; |
Contributor
There was a problem hiding this comment.
Let's consider using RetryReadPolicy by default?
Contributor
Author
There was a problem hiding this comment.
Agree, done.
RetryReadPolicyis now default in .NET and Java clients.RetryLimitdefaults to16to we don't retry infinitely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RetryPolicyinterface.RetryReadPolicy,RetryLimitPolicy(default limit is 16).IgniteClientConfiguration.retryPolicyproperty, defaults toRetryReadPolicy.IgniteClientConfiguration.retryLimit- limit can be handled by the policy.RetryAllPolicy- it is the same asRetryLimitPolicywith a zero limit.RetryLimitPolicy.RetryLimitto 16 by default.RetryReadPolicyas default.https://cwiki.apache.org/confluence/display/IGNITE/IEP-82+Thin+Client+Retry+Policy