IGNITE-16792 Configuration for Default Storage Engine#763
Merged
ibessonov merged 15 commits intoapache:mainfrom Apr 11, 2022
Merged
IGNITE-16792 Configuration for Default Storage Engine#763ibessonov merged 15 commits intoapache:mainfrom
ibessonov merged 15 commits intoapache:mainfrom
Conversation
ibessonov
reviewed
Apr 8, 2022
.../main/java/org/apache/ignite/configuration/schemas/store/DataStorageConfigurationSchema.java
Outdated
Show resolved
Hide resolved
modules/api/src/main/java/org/apache/ignite/configuration/schemas/store/ExistDataStorage.java
Outdated
Show resolved
Hide resolved
modules/api/src/main/java/org/apache/ignite/configuration/schemas/store/KnownDataStorage.java
Outdated
Show resolved
Hide resolved
...on-processor/src/main/java/org/apache/ignite/internal/configuration/processor/Processor.java
Outdated
Show resolved
Hide resolved
...on/src/test/java/org/apache/ignite/internal/configuration/validation/TestValidationUtil.java
Outdated
Show resolved
Hide resolved
...torage-api/src/main/java/org/apache/ignite/internal/storage/engine/StorageEngineFactory.java
Outdated
Show resolved
Hide resolved
...les/storage-api/src/test/java/org/apache/ignite/internal/storage/DataStorageManagerTest.java
Show resolved
Hide resolved
| ) TableConfiguration tableCfg | ||
| ) throws Exception { | ||
| assertThat(tableCfg.dataStorage(), is(instanceOf(RocksDbDataStorageConfiguration.class))); | ||
| CompletableFuture<Void> changeDataStorageFuture = tableCfg.dataStorage().change(c -> c.convert(RocksDbDataStorageChange.class)); |
Contributor
There was a problem hiding this comment.
In previous test you just wait 1 second, but here you assert that it'll give you null eventually. Why?
Contributor
Author
There was a problem hiding this comment.
Also done below, can make a wait of 1 second. WDYT?
Contributor
There was a problem hiding this comment.
I don't mind any solution, just wondering why it's inconsistent
Contributor
Author
There was a problem hiding this comment.
I didn’t quite understand, but if it’s a minor, then we’ll leave it
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java
Show resolved
Hide resolved
modules/table/src/test/java/org/apache/ignite/internal/table/TableManagerTest.java
Outdated
Show resolved
Hide resolved
ibessonov
approved these changes
Apr 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-16792