Skip to content

Conversation

@rpuch
Copy link
Contributor

@rpuch rpuch commented Apr 18, 2022

Copy link
Contributor

@SammyVimes SammyVimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SammyVimes SammyVimes merged commit 6df9719 into apache:main Apr 20, 2022
@SammyVimes SammyVimes deleted the ignite-16573 branch April 20, 2022 10:20
@rpuch
Copy link
Contributor Author

rpuch commented Apr 20, 2022

Thanks for the review

isapego pushed a commit to isapego/ignite-3 that referenced this pull request Dec 26, 2024
…platform (apache#785)

* GG-39251 Adds EncryptionSupportedValidatorImpl

** This class checks if the encryption is supported on the current OS

* GG-39251 Starts using the EncryptionSupportedValidator to validate the Encryption Configurations

* GG-39251 Removes error log from EncryptionPluginUtils#isEncryptionSupported in favour of assert

* GG-39251 Disables encryption tests outside of linux

* GG-39251 Applies code reviews

** Promoted assertThrows to Utility class
** Fixed javadoc on EncryptionSupported

* GG-39251 Applies code reviews

** Moved assertThrows to EncryptionTestUtils
** Copied the javadoc from IgniteTestUtils
** Removed link to remove dependency from IgniteTestUtils.

* GG-39251 Applies code reviews

** Renamed EncryptionSupported to RequiresEncryptionSupport
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants