IGNITE-28345 Skip client compute notification on executionFut fail#7906
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes IGNITE-28345 by preventing client compute result notifications from being sent when the initial job submission (executionFut) fails, avoiding protocol-level “unexpected notification” scenarios on the client side.
Changes:
- Update compute execute notification flow to skip sending notifications when
executionFutcompletes exceptionally. - Add TeamCity Linux .NET log fail conditions to immediately fail builds on “Unexpected notification ID” / “Unexpected response ID”.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/compute/ClientComputeExecuteRequest.java | Avoids sending compute result notifications when submission fails (no JobExecution available). |
| .teamcity/test/platform_tests/PlatformDotnetTestsLinux.kt | Makes CI fail fast on protocol desync log signatures in .NET platform tests. |
Comments suppressed due to low confidence (1)
modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/compute/ClientComputeExecuteRequest.java:144
sendResultAndStateignoreserrStatefromexecution.stateAsync(): if state retrieval fails while the result succeeds, the notification is still sent as successful and the state is packed asnil, which can hide the underlying failure. Consider passing a combined error (first non-null oferranderrState) for consistency withClientComputeExecuteMapReduceRequest(which usesIgniteUtils.firstNotNull).
execution.resultAsync().whenComplete((val, err) ->
execution.stateAsync().whenComplete((state, errState) -> {
try {
notificationSender.sendNotification(
w -> {
Marshaller<Object, byte[]> marshaller = extractMarshaller(execution);
ClientComputeJobPacker.packJobResult(val, marshaller, w);
packJobState(w, state);
},
err,
hybridTimestamp(val));
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
isapego
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-28345