Skip to content

IGNITE-28418 Add more diagnostic to page lock timeouts#7910

Merged
ibessonov merged 9 commits into
apache:mainfrom
gridgain:ignite-28418
Apr 6, 2026
Merged

IGNITE-28418 Add more diagnostic to page lock timeouts#7910
ibessonov merged 9 commits into
apache:mainfrom
gridgain:ignite-28418

Conversation

@ibessonov
Copy link
Copy Markdown
Contributor

https://issues.apache.org/jira/browse/IGNITE-28418

Thank you for submitting the pull request.

To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:

The Review Checklist

  • Formal criteria: TC status, codestyle, mandatory documentation. Also make sure to complete the following:
    - There is a single JIRA ticket related to the pull request.
    - The web-link to the pull request is attached to the JIRA ticket.
    - The JIRA ticket has the Patch Available state.
    - The description of the JIRA ticket explains WHAT was made, WHY and HOW.
    - The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • Design: new code conforms with the design principles of the components it is added to.
  • Patch quality: patch cannot be split into smaller pieces, its size must be reasonable.
  • Code quality: code is clean and readable, necessary developer documentation is added if needed.
  • Tests code quality: test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.

Notes

Signed-off-by: ibessonov <bessonov.ip@gmail.com>
Signed-off-by: ibessonov <bessonov.ip@gmail.com>
Signed-off-by: ibessonov <bessonov.ip@gmail.com>
Signed-off-by: ibessonov <bessonov.ip@gmail.com>
Signed-off-by: ibessonov <bessonov.ip@gmail.com>
Signed-off-by: ibessonov <bessonov.ip@gmail.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR (IGNITE-28418) enhances diagnostics for page/off-heap lock acquisition timeouts by capturing and reporting additional context about the lock holder.

Changes:

  • Extend OffheapReadWriteLock off-heap state to store the current write-lock owner thread id and include it in timeout diagnostics.
  • Update PageHeader in-memory header layout to account for the larger lock structure and make flag updates CAS-based.
  • Add ThreadUtils.dumpThread(...) helper to dump a single thread by id; minor refactor in synchronizer dump handling.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/PageHeader.java Recomputes header offsets/overhead using the new lock size; makes flag updates atomic (CAS).
modules/core/src/main/java/org/apache/ignite/internal/util/OffheapReadWriteLock.java Adds write-owner thread id tracking in offheap memory and emits thread dump + ownerId on lock timeout.
modules/core/src/main/java/org/apache/ignite/internal/thread/ThreadUtils.java Adds single-thread dump utility and tightens null-handling for locked synchronizers output.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread modules/core/src/main/java/org/apache/ignite/internal/thread/ThreadUtils.java Outdated
Signed-off-by: ibessonov <bessonov.ip@gmail.com>
@ibessonov ibessonov merged commit 7fc6ae8 into apache:main Apr 6, 2026
5 checks passed
@ibessonov ibessonov deleted the ignite-28418 branch April 6, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants