IGNITE-28418 Add more diagnostic to page lock timeouts#7910
Merged
Conversation
Signed-off-by: ibessonov <bessonov.ip@gmail.com>
Signed-off-by: ibessonov <bessonov.ip@gmail.com>
Signed-off-by: ibessonov <bessonov.ip@gmail.com>
Signed-off-by: ibessonov <bessonov.ip@gmail.com>
Signed-off-by: ibessonov <bessonov.ip@gmail.com>
Signed-off-by: ibessonov <bessonov.ip@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR (IGNITE-28418) enhances diagnostics for page/off-heap lock acquisition timeouts by capturing and reporting additional context about the lock holder.
Changes:
- Extend
OffheapReadWriteLockoff-heap state to store the current write-lock owner thread id and include it in timeout diagnostics. - Update
PageHeaderin-memory header layout to account for the larger lock structure and make flag updates CAS-based. - Add
ThreadUtils.dumpThread(...)helper to dump a single thread by id; minor refactor in synchronizer dump handling.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/PageHeader.java | Recomputes header offsets/overhead using the new lock size; makes flag updates atomic (CAS). |
| modules/core/src/main/java/org/apache/ignite/internal/util/OffheapReadWriteLock.java | Adds write-owner thread id tracking in offheap memory and emits thread dump + ownerId on lock timeout. |
| modules/core/src/main/java/org/apache/ignite/internal/thread/ThreadUtils.java | Adds single-thread dump utility and tightens null-handling for locked synchronizers output. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: ibessonov <bessonov.ip@gmail.com>
alievmirza
reviewed
Apr 6, 2026
Signed-off-by: ibessonov <bessonov.ip@gmail.com>
alievmirza
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-28418
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
The Review Checklist
- There is a single JIRA ticket related to the pull request.
- The web-link to the pull request is attached to the JIRA ticket.
- The JIRA ticket has the Patch Available state.
- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
Notes