IGNITE-28413 Java client: fix race condition in message decoder#7926
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses a Java thin client race condition in Netty message decoding where the same ByteBuf (and its indices/content) can be modified concurrently by Netty’s internal discard logic and by response decoding on another thread, leading to data corruption.
Changes:
- Make
ClientMessageDecoderfinal. - Disable (or attempt to effectively disable) Netty’s automatic
discardReadBytes/discardSomeReadBytesbehavior viasetDiscardAfterReads(Integer.MAX_VALUE). - Annotate the
decode(...)override as@Nullableand remove the related suppression.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
isapego
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable automatic
discardReadBytesin Netty to fix a race condition and data corruption caused by concurrent buffer modification:discardSomeReadByteson IO thread, which changesreaderIndexTcpClientChannel.asyncContinuationExecutordecodes the response on another thread, which also uses and changesreaderIndexhttps://issues.apache.org/jira/browse/IGNITE-28413