Skip to content

IGNITE-28453 Avoid index key materialization during index row verification#7932

Merged
korlov42 merged 3 commits intoapache:mainfrom
gridgain:ignite-28453
Apr 7, 2026
Merged

IGNITE-28453 Avoid index key materialization during index row verification#7932
korlov42 merged 3 commits intoapache:mainfrom
gridgain:ignite-28453

Conversation

@korlov42
Copy link
Copy Markdown
Contributor

@korlov42 korlov42 commented Apr 4, 2026

https://issues.apache.org/jira/browse/IGNITE-28453

Results of the benchmark on my laptop:

Before
Benchmark                                        (fsync)  (partitions)  (prefixLength)  (remote)  Mode  Cnt         Score         Error   Units
SqlIndexScanBenchmarkV2.test                       false            24             128     false  avgt   20         6.737 ±       0.053   ms/op
SqlIndexScanBenchmarkV2.test:gc.alloc.rate         false            24             128     false  avgt   20      3624.612 ±     740.794  MB/sec
SqlIndexScanBenchmarkV2.test:gc.alloc.rate.norm    false            24             128     false  avgt   20  25623485.830 ± 5224831.261    B/op
SqlIndexScanBenchmarkV2.test:gc.count              false            24             128     false  avgt   20       267.000                counts
SqlIndexScanBenchmarkV2.test:gc.time               false            24             128     false  avgt   20       650.000                    ms


After
Benchmark                                        (fsync)  (partitions)  (prefixLength)  (remote)  Mode  Cnt         Score         Error   Units
SqlIndexScanBenchmarkV2.test                       false            24             128     false  avgt   20         6.607 ±       0.065   ms/op
SqlIndexScanBenchmarkV2.test:gc.alloc.rate         false            24             128     false  avgt   20      3384.932 ±     692.342  MB/sec
SqlIndexScanBenchmarkV2.test:gc.alloc.rate.norm    false            24             128     false  avgt   20  23473230.357 ± 4789622.870    B/op
SqlIndexScanBenchmarkV2.test:gc.count              false            24             128     false  avgt   20       256.000                counts
SqlIndexScanBenchmarkV2.test:gc.time               false            24             128     false  avgt   20       585.000                    ms

Thank you for submitting the pull request.

To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:

The Review Checklist

  • Formal criteria: TC status, codestyle, mandatory documentation. Also make sure to complete the following:
    - There is a single JIRA ticket related to the pull request.
    - The web-link to the pull request is attached to the JIRA ticket.
    - The JIRA ticket has the Patch Available state.
    - The description of the JIRA ticket explains WHAT was made, WHY and HOW.
    - The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • Design: new code conforms with the design principles of the components it is added to.
  • Patch quality: patch cannot be split into smaller pieces, its size must be reasonable.
  • Code quality: code is clean and readable, necessary developer documentation is added if needed.
  • Tests code quality: test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.

Notes

korlov42 added 2 commits April 7, 2026 15:17
- introduced *Accessor local fields
- added microbenchmark to measure BinaryRowConverter in isolation
- added test for columnsMatch and BinaryTuplePrinter
@korlov42 korlov42 merged commit a0ec2ec into apache:main Apr 7, 2026
5 checks passed
@korlov42 korlov42 deleted the ignite-28453 branch April 7, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants