Skip to content

IGNITE-28460 Sql. Choose commit partition from list of involved partitions#7936

Merged
korlov42 merged 4 commits intoapache:mainfrom
gridgain:ignite-28460
Apr 7, 2026
Merged

IGNITE-28460 Sql. Choose commit partition from list of involved partitions#7936
korlov42 merged 4 commits intoapache:mainfrom
gridgain:ignite-28460

Conversation

@korlov42
Copy link
Copy Markdown
Contributor

@korlov42 korlov42 commented Apr 6, 2026

https://issues.apache.org/jira/browse/IGNITE-28460


Thank you for submitting the pull request.

To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:

The Review Checklist

  • Formal criteria: TC status, codestyle, mandatory documentation. Also make sure to complete the following:
    - There is a single JIRA ticket related to the pull request.
    - The web-link to the pull request is attached to the JIRA ticket.
    - The JIRA ticket has the Patch Available state.
    - The description of the JIRA ticket explains WHAT was made, WHY and HOW.
    - The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • Design: new code conforms with the design principles of the components it is added to.
  • Patch quality: patch cannot be split into smaller pieces, its size must be reasonable.
  • Code quality: code is clean and readable, necessary developer documentation is added if needed.
  • Tests code quality: test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.

Notes

korlov42 added 3 commits April 7, 2026 09:47
- reworked partition enlistment: replaced tree traversing with loop
- made commit partition assignment optional: assign only if none was assigned before
- added check in the test that none unexpected enlistment/assignment happened
@korlov42 korlov42 merged commit 784e098 into apache:main Apr 7, 2026
5 checks passed
@korlov42 korlov42 deleted the ignite-28460 branch April 7, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants